Implement dpdk_build_check #72
Conversation
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
requested review from
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
- Do krnlmon checks in the context of networking-recipe instead of using standalone mode. Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
added
minor effort
| export DEPEND_INSTALL=$DEPS_INSTALL_DIR | ||
| export SDE_INSTALL=$SDE_INSTALL_DIR | ||
| ./make-all.sh --target=dpdk --rpath --no-ovs --no-build | ||
| cmake --build build -j4 --target krnlmon |
There was a problem hiding this comment.
--target krnlmon?
What does this mean?
There was a problem hiding this comment.
It instructs cmake to build the krnlmon target. It's the equivalent of make -C build krnlmon.
There was a problem hiding this comment.
I didnt realize krnlmon target was supported
There was a problem hiding this comment.
We're just full of surprises. 😉
There was a problem hiding this comment.
Since krnlmon is treated as separate target, is krnlmon a separate process and not a thread anymore? Do we need to start krnlmon separately?
There was a problem hiding this comment.
This workflow just checks to see if krnlmon compiles okay. The output is a library (libkrnlmon). The result is not runnable.
The workflow runs when a PR is created against the krnlmon repository. Anything we do here should be largely independent of networking-recipe. (There's a weakness here, in that krnlmon depends on several include files in networking-recipe/cmake. I'm crossing my fingers that this does not become an issue. I should probably move them to a separate repository and include it as a submodule, but I've been reluctant to do so for so few files.)
Krnlmon has very few dependencies, so the process completes in ~30 seconds. We want our build checks to be fast.
GitHub reports that "some checks haven't completed yet" because I renamed
check_krnlmon_dpdktodpdk_unit_tests. This issue will go away once I update the list of required checks (after merging this PR).