Address clang-tidy issues #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deal with a couple of unreferenced variables. - Remove gratuitous parentheses. Signed-off-by: Derek Foster <[email protected]>
ffoulkes
requested review from
5abeel,
n-sandeep and
vsureshkumarp
as code owners
ffoulkes
commented
Oct 4, 2024
| @@ -216,7 +216,6 @@ void switchlink_process_link_msg(const struct nlmsghdr* nlmsg, int msgtype) { | |||
| int linkinfo_attr_type; | |||
|
|
|||
| switchlink_db_interface_info_t intf_info = {0}; | |||
| switchlink_db_tunnel_interface_info_t tnl_intf_info = {0}; | |||
There was a problem hiding this comment.
Unreferenced variable. Moved inside #ifdef block.
5abeel
reviewed
Oct 4, 2024
| @@ -123,11 +123,6 @@ void switchlink_process_neigh_msg(const struct nlmsghdr* nlmsg, int msgtype) { | |||
| } else { | |||
| intf_h = ifinfo.intf_h; | |||
| } | |||
| switchlink_handle_t bridge_h = g_default_bridge_h; | |||
| if (ifinfo.intf_type == SWITCHLINK_INTF_TYPE_L2_ACCESS) { | |||
There was a problem hiding this comment.
why are we removing this block?
There was a problem hiding this comment.
clang-tidy flagged bridge_h as an unreferenced variable. It's only used in the krnlmon_assert statement, which is disabled unless we build krnlmon in Debug mode. I didn't see this as a compelling reason to preserve what is otherwise dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with a couple of unreferenced variables.
Remove gratuitous parentheses.