LNW nexthop changes for LAG scenario #155
Conversation
Signed-off-by: Sabeel Ansari <[email protected]>
5abeel
requested review from
ffoulkes,
n-sandeep and
vsureshkumarp
as code owners
Signed-off-by: Sabeel Ansari <[email protected]>
There was a problem hiding this comment.
This PR needs a good changelist comment.
See Writing good CL descriptions for an excellent description of how to do this.
I'd recommend doing this in the comment box at the top of the PR, and then copy/pasting it into the comment box when merging the PR.
See my second comment for ideas on what information you might provide.
Signed-off-by: Sabeel Ansari <[email protected]>
| status = tdi_data_field_set_value(data_hdl, rif_data_field_id, lag_id); | ||
| if (status != TDI_SUCCESS) { | ||
| krnlmon_log_error("Unable to set action value for ID: %d, error: %d", | ||
| data_field_id, status); |
There was a problem hiding this comment.
data_field_id, --> change this to rif_data_field_id for correct error message.
There was a problem hiding this comment.
Opened PR #156 to address this
| &rif_data_field_id); | ||
| if (status != TDI_SUCCESS) { | ||
| krnlmon_log_error("Unable to get data field id param for: %s, error: %d", | ||
| ACTION_SET_EGRESS_PORT_PARAM_EGRESS_PORT, status); |
There was a problem hiding this comment.
ACTION_SET_EGRESS_PORT_PARAM_EGRESS_PORT -> Change this to ACTION_SET_EGRESS_PORT_PARAM_ROUTER_INTF_ID for correct error message.
There was a problem hiding this comment.
Opened PR #156 to address this
router_interface_idargument fromset_nexthop_lagaction innexthop_table.router_interface_idwithset_egress_portaction fortx_lag_tableto resolve source MAC address population for LAG scenario.This aligns with recent changes in the P4 program to address a LAG bug.