Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac target localhost container via gemini openai proxy #94

Conversation

lloydchang
Copy link
Contributor

No description provided.

@lloydchang
Copy link
Contributor Author

lloydchang commented Nov 14, 2024

Relates to Implement additional gemini backend #84
create onboarding/quickstart blog post as well as video #36
docs(README.md): add Mac use case #95

@andreashappe
Copy link
Member

I will merge this for now.. would it be possible to move some of the shell-script functions into a common shellscript and include this from the different scripts (similar to a library)?

@andreashappe andreashappe merged commit 6ee3f10 into ipa-lab:main Nov 14, 2024
1 check passed
@lloydchang
Copy link
Contributor Author

lloydchang commented Nov 14, 2024

Thank you for merging.

Refactoring the functions for Mac and Linux into a library seems like premature optimization to me:

  • Since Mac (which is BSD-based) and Codespaces (which is Linux) don't share a common underlying platform, it can be challenging to reuse and share code between them.

  • Additionally, the two shell scripts on Mac may not operate in the same shell environment, as they could be using different versions of Bash—version 5 from Homebrew versus version 3 from Apple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants