Fix clippy warnings

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rssbot"
-version = "1.3.0"
+version = "1.3.2"
 authors = ["iovxw <[email protected]>"]
 license = "Unlicense"
 readme = "README.md"

src/cmdhandles.rs

@@ -198,7 +198,7 @@ fn register_sub(bot: &telebot::RcBot, db: Database, lphandle: Handle) {
                 })
         })
         .and_then(|(bot, db, subscriber, chat_id, feed)| {
-            match db.subscribe(subscriber, &feed.source.as_ref().unwrap(), &feed) {
+            match db.subscribe(subscriber, feed.source.as_ref().unwrap(), &feed) {
                 Ok(_) => {
                     bot.message(
                         chat_id,
@@ -471,6 +471,6 @@ fn check_channel<'a>(
 
         await!(bot.delete_message(chat_id, msg_id).send())?;
 
-        return Ok(Some(channel_id));
+        Ok(Some(channel_id))
     }
 }

src/data.rs

@@ -219,7 +219,7 @@ pub struct Database {
 
 impl Clone for Database {
     fn clone(&self) -> Database {
-        Database { inner: self.inner.clone() }
+        Database { inner: Rc::clone(&self.inner) }
     }
 }
 

src/feed.rs

@@ -312,7 +312,7 @@ fn make_request(
     ua: String,
     mut recur_limit: usize,
 ) -> Result<(Vec<u8>, String, u32)> {
-    let mut location = None;
+    let mut location: Option<String> = None;
     loop {
         if recur_limit == 0 {
             break Err(ErrorKind::TooManyRedirects.into());
@@ -321,10 +321,10 @@ fn make_request(
         let buf = Arc::new(Mutex::new(Vec::new()));
         let location_buf = Arc::new(Mutex::new(String::new()));
         {
-            let buf = buf.clone();
-            let location_buf = location_buf.clone();
+            let buf = Arc::clone(&buf);
+            let location_buf = Arc::clone(&location_buf);
             req.get(true).unwrap();
-            req.url(&location.as_ref().unwrap_or(&source)).unwrap();
+            req.url(location.as_ref().unwrap_or(&source)).unwrap();
             req.accept_encoding("").unwrap(); // accept all encoding
             req.useragent(&ua).unwrap();
             req.timeout(Duration::from_secs(10)).unwrap();

src/fetcher.rs

@@ -78,7 +78,7 @@ fn get_host(url: &str) -> &str {
 }
 
 #[async]
-fn fetch_feed_updates<'a>(
+fn fetch_feed_updates(
     bot: telebot::RcBot,
     db: data::Database,
     session: Session,
@@ -131,8 +131,8 @@ fn fetch_feed_updates<'a>(
     let feed::RSS {
         title: rss_title,
         link: rss_link,
-        source: _,
         items: rss_items,
+        ..
     } = rss;
     let updates = db.update(&feed.link, rss_items);
     if updates.is_empty() {
@@ -168,7 +168,7 @@ fn fetch_feed_updates<'a>(
                 warn!("failed to send updates to {}, {:?}", subscriber, e);
             }
         }
-        if let &Some(ref rss) = &moved {
+        if let Some(ref rss) = moved {
             // ignore error
             let _ = db.unsubscribe(subscriber, &feed.link);
             let _ = db.subscribe(subscriber, rss.source.as_ref().unwrap(), rss);

src/utlis.rs

@@ -128,8 +128,8 @@ pub fn to_chinese_error_msg(e: errors::Error) -> String {
 }
 
 pub fn chat_is_unavailable(e: &telebot::error::Error) -> bool {
-    match e {
-        &telebot::error::Error::Telegram(_, ref s, _)
+    match *e {
+        telebot::error::Error::Telegram(_, ref s, _)
             if s.contains("Forbidden") || s.contains("chat not found") ||
                    s.contains("group chat was migrated to a supergroup chat") => true,
         _ => false,