Fix a bug in getActionsByAddress (#1568)

api/api.go

@@ -725,6 +725,9 @@ func (api *Server) getActionsFromIndex(totalActions, start, count uint64) (*iote
 
 // GetActions returns actions within the range
 func (api *Server) getActions(start uint64, count uint64) (*iotexapi.GetActionsResponse, error) {
+	if count == 0 {
+		return nil, status.Error(codes.InvalidArgument, "count must be greater than zero")
+	}
 	if count > api.cfg.API.RangeQueryLimit {
 		return nil, status.Error(codes.InvalidArgument, "range exceeds the limit")
 	}
@@ -794,6 +797,9 @@ func (api *Server) getSingleAction(actionHash string, checkPending bool) (*iotex
 
 // getActionsByAddress returns all actions associated with an address
 func (api *Server) getActionsByAddress(address string, start uint64, count uint64) (*iotexapi.GetActionsResponse, error) {
+	if count == 0 {
+		return nil, status.Error(codes.InvalidArgument, "count must be greater than zero")
+	}
 	if count > api.cfg.API.RangeQueryLimit {
 		return nil, status.Error(codes.InvalidArgument, "range exceeds the limit")
 	}
@@ -819,6 +825,9 @@ func (api *Server) getActionsByAddress(address string, start uint64, count uint6
 
 // getUnconfirmedActionsByAddress returns all unconfirmed actions in actpool associated with an address
 func (api *Server) getUnconfirmedActionsByAddress(address string, start uint64, count uint64) (*iotexapi.GetActionsResponse, error) {
+	if count == 0 {
+		return nil, status.Error(codes.InvalidArgument, "count must be greater than zero")
+	}
 	if count > api.cfg.API.RangeQueryLimit {
 		return nil, status.Error(codes.InvalidArgument, "range exceeds the limit")
 	}
@@ -847,6 +856,9 @@ func (api *Server) getUnconfirmedActionsByAddress(address string, start uint64,
 
 // getActionsByBlock returns all actions in a block
 func (api *Server) getActionsByBlock(blkHash string, start uint64, count uint64) (*iotexapi.GetActionsResponse, error) {
+	if count == 0 {
+		return nil, status.Error(codes.InvalidArgument, "count must be greater than zero")
+	}
 	if count > api.cfg.API.RangeQueryLimit {
 		return nil, status.Error(codes.InvalidArgument, "range exceeds the limit")
 	}
@@ -875,6 +887,9 @@ func (api *Server) getActionsByBlock(blkHash string, start uint64, count uint64)
 
 // getBlockMetas returns blockmetas response within the height range
 func (api *Server) getBlockMetas(start uint64, count uint64) (*iotexapi.GetBlockMetasResponse, error) {
+	if count == 0 {
+		return nil, status.Error(codes.InvalidArgument, "count must be greater than zero")
+	}
 	if count > api.cfg.API.RangeQueryLimit {
 		return nil, status.Error(codes.InvalidArgument, "range exceeds the limit")
 	}
@@ -1155,6 +1170,9 @@ func (api *Server) reverseActionsInBlock(blk *block.Block, reverseStart, count u
 }
 
 func (api *Server) getLogsInBlock(filter *LogFilter, start, count uint64) ([]*iotextypes.Log, error) {
+	if count == 0 {
+		return nil, status.Error(codes.InvalidArgument, "count must be greater than zero")
+	}
 	// filter logs within start --> end
 	var logs []*iotextypes.Log
 	end := start + count - 1

api/api_test.go

@@ -679,12 +679,12 @@ func TestServer_GetActions(t *testing.T) {
 			},
 		}
 		res, err := svr.GetActions(context.Background(), request)
+		if test.count == 0 {
+			require.Error(err)
+			continue
+		}
 		require.NoError(err)
 		require.Equal(test.numActions, len(res.ActionInfo))
-		if test.numActions == 0 {
-			// returns empty response body in case of no result
-			require.Equal(&iotexapi.GetActionsResponse{}, res)
-		}
 	}
 }
 
@@ -792,15 +792,13 @@ func TestServer_GetUnconfirmedActionsByAddress(t *testing.T) {
 			},
 		}
 		res, err := svr.GetActions(context.Background(), request)
+		if test.count == 0 {
+			require.Error(err)
+			continue
+		}
 		require.NoError(err)
 		require.Equal(test.numActions, len(res.ActionInfo))
-		if test.numActions > 0 {
-			require.Equal(test.address, res.ActionInfo[0].Sender)
-		} else {
-			// returns empty response body in case of no result
-			res.Total = 0
-			require.Equal(&iotexapi.GetActionsResponse{}, res)
-		}
+		require.Equal(test.address, res.ActionInfo[0].Sender)
 	}
 }
 
@@ -825,15 +823,13 @@ func TestServer_GetActionsByBlock(t *testing.T) {
 			},
 		}
 		res, err := svr.GetActions(context.Background(), request)
+		if test.count == 0 {
+			require.Error(err)
+			continue
+		}
 		require.NoError(err)
 		require.Equal(test.numActions, len(res.ActionInfo))
-		if test.numActions > 0 {
-			require.Equal(test.blkHeight, res.ActionInfo[0].BlkHeight)
-		} else {
-			// returns empty response body in case of no result
-			res.Total = 0
-			require.Equal(&iotexapi.GetActionsResponse{}, res)
-		}
+		require.Equal(test.blkHeight, res.ActionInfo[0].BlkHeight)
 	}
 }
 
@@ -854,6 +850,10 @@ func TestServer_GetBlockMetas(t *testing.T) {
 			},
 		}
 		res, err := svr.GetBlockMetas(context.Background(), request)
+		if test.count == 0 {
+			require.Error(err)
+			continue
+		}
 		require.NoError(err)
 		require.Equal(test.numBlks, len(res.BlkMetas))
 		var prevBlkPb *iotextypes.BlockMeta

blockchain/blockdao.go

@@ -405,6 +405,9 @@ func (dao *blockDAO) getActionsByAddress(addrBytes hash.Hash160, start, count ui
 		return nil, err
 	}
 	total := address.Size()
+	if start >= total {
+		return nil, errors.New("invalid start index")
+	}
 	if start+count > total {
 		count = total - start
 	}