Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gon fork for notarizing macOS Node.js bindings #2226

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Use gon fork for notarizing macOS Node.js bindings #2226

merged 1 commit into from
Apr 17, 2024

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Apr 16, 2024 •
edited
Loading

Description of change

See #1546

Links to any relevant issues

N/A

Type of change

  • Chore

How the change has been tested

Hasn't been tested, package version needs to be bumped

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@rajivshah3 rajivshah3 marked this pull request as ready for review April 17, 2024 00:29
@thibault-martinez thibault-martinez merged commit 0694acf into 2.0 Apr 17, 2024
1 of 2 checks passed
@thibault-martinez thibault-martinez deleted the chore/2.0-notarization branch April 17, 2024 07:45
@thibault-martinez
Copy link
Member

Thanks <3

@rajivshah3 rajivshah3 mentioned this pull request Apr 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajivshah3 @thibault-martinez @Thoralf-M