Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wait_for_transaction_acceptance #2177

Merged

Conversation

Thoralf-M
Copy link
Member

Description of change

Don't error with NotFound for the first attempts in wait_for_transaction_acceptance as the node may not have fully processed the tx at this point

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Sending transactions with many outputs and then calling wait_for_transaction_acceptance() on them which failed before

2024-03-13 08:37:57 (UTC) iota_sdk::client::api::wait_for_tx_acceptance DEBUG [wait_for_transaction_acceptance]
2024-03-13 08:37:57 (UTC) iota_sdk::client::node_manager::http_client DEBUG GET: 36 ms for 404 Not Found http://localhost:8050/api/core/v3/transactions/0x8a502496881e05fa5ed60a86c605e8c93d21fdaeb07220dd41fbf884d9ec16d5e6a50000/metadata
2024-03-13 08:37:58 (UTC) iota_sdk::client::node_manager::http_client DEBUG GET: 35 ms for 200 OK http://localhost:8050/api/core/v3/transactions/0x8a502496881e05fa5ed60a86c605e8c93d21fdaeb07220dd41fbf884d9ec16d5e6a50000/metadata

…ion_acceptance as the node may not have fully processed the tx at this point
@Thoralf-M Thoralf-M self-assigned this Mar 13, 2024
@Thoralf-M Thoralf-M marked this pull request as ready for review March 13, 2024 09:06
Alex6323
Alex6323 previously approved these changes Mar 13, 2024
@Thoralf-M Thoralf-M merged commit 05cf681 into iotaledger:2.0 Mar 14, 2024
37 checks passed
@Thoralf-M Thoralf-M deleted the wait-for-tx-acceptance-improvement branch March 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants