NodeJs: sweet improvements 🍓 #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Alex6323
force-pushed
the
alias-mismatch
branch
from
c05a3b7
to
59b60bd
Compare
Thoralf-M
previously approved these changes
Mar 11, 2024
3 tasks
|
Shouldn't we just overwrite it? I mean it's just an alias. |
could maybe be used to trick someone to enter the stronghold password ... I would be conservative here and not do that. I'ld rather have some explicit command that says |
Thoralf-M
approved these changes
Mar 18, 2024
DaughterOfMars
approved these changes
Mar 18, 2024
Alex6323
changed the title
WalletBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR:
adds a newWalletErrorvariant:AliasMismatch { provided: String, expected: String };returns that error in case a provided alias conflicts with the one stored in the wallet db;UPDATE: after a call we decided to remove this alias mismatch detection from this PR,
because we don't think there's a real problem with the builder overwriting the alias
stored in the db since this is non-critical data. I kept the other changes unrelated to
the wallet alias, which are:
wallet.spec.tstestsLinks to any relevant issues
Fixes #2016
How the change has been tested
Integration tests.