-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allotment touchups #2036
Merged
Merged
Allotment touchups #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in_allot_account_mana_requirement_twice' panicked at sdk\tests\client\input_selection\account_outputs.rs:1937:6:
called Result::unwrap()
on an Err
value: InsufficientMana { found: 1100, required: 1880 }
Thoralf-M
reviewed
Feb 21, 2024
Thoralf-M
reviewed
Feb 21, 2024
Thoralf-M
reviewed
Feb 23, 2024
…er/iota-sdk into feat/allotment-touchups
Thoralf-M
approved these changes
Feb 23, 2024
Alex6323
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In order to provide more fine-grained control over ISA, I have added a new flag to the transaction options to control whether ISA can use account mana for allotments. It will only remove mana for the minimum allotment and only from an account output with the
account_id == issuer_id
. This extends to the CLI, so that for staking operations users can now set this flag.I also reworked the way that the mana requirement selects inputs so that it can also add the output mana to the equation. This means that the calculation will be the same regardless of whether the inputs are passed in or added later.