Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allotment touchups #2036

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Allotment touchups #2036

merged 14 commits into from
Feb 23, 2024

Conversation

DaughterOfMars
Copy link

Description of change

In order to provide more fine-grained control over ISA, I have added a new flag to the transaction options to control whether ISA can use account mana for allotments. It will only remove mana for the minimum allotment and only from an account output with the account_id == issuer_id. This extends to the CLI, so that for staking operations users can now set this flag.

I also reworked the way that the mana requirement selects inputs so that it can also add the output mana to the equation. This means that the calculation will be the same regardless of whether the inputs are passed in or added later.

Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in_allot_account_mana_requirement_twice' panicked at sdk\tests\client\input_selection\account_outputs.rs:1937:6:
called Result::unwrap() on an Err value: InsufficientMana { found: 1100, required: 1880 }

@DaughterOfMars DaughterOfMars linked an issue Feb 22, 2024 that may be closed by this pull request
@DaughterOfMars DaughterOfMars merged commit 8712869 into 2.0 Feb 23, 2024
37 checks passed
@DaughterOfMars DaughterOfMars deleted the feat/allotment-touchups branch February 23, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISA should not mutate user provided outputs
3 participants