Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Google Analytics: API Update #1392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cxaviousb
Copy link

The Google Analytics package that this project calls has been updated in a backwards incompatible manner. These edits are updates to address these changes.

This API clash is currently causing users of ng-cordova to be unable to log properly in Google Analytics after fresh builds.

The Google Analytics package that this project calls has been updated in a backwards incompatible manner.  These edits are updates to address these changes.
@cxaviousb
Copy link
Author

cxaviousb commented Dec 12, 2016

Note:

  1. For an unknown reason (at least to me), a unit test is broken for $cordovaToast before I made any edits. Not sure what's causing it, but it should be pop up if retest your master branch as well.
  2. This contains the same edits as Google Analytics: API Update #1393 which is based off the dev-next branch instead, given you might be pushing a new release for this project instead of publishing just a bug fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant