Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress ktor R8 warning #35

Merged
merged 12 commits into from
Oct 7, 2024
Merged

Suppress ktor R8 warning #35

merged 12 commits into from
Oct 7, 2024

Conversation

elmira-y
Copy link
Collaborator

@elmira-y elmira-y commented Oct 7, 2024 •
edited
Loading

closes #34

Changes

  • Add consumer-rules.pro to androidMain
  • build.gradle: Set consumerProguardFiles in android block

@elmira-y elmira-y marked this pull request as draft October 7, 2024 09:13
StefMa
StefMa reviewed Oct 7, 2024
View reviewed changes
library/build.gradle.kts Outdated Show resolved Hide resolved
@elmira-y elmira-y marked this pull request as ready for review October 7, 2024 13:12
@elmira-y elmira-y requested a review from StefMa October 7, 2024 13:12
StefMa
StefMa reviewed Oct 7, 2024
View reviewed changes
library/build.gradle.kts Outdated Show resolved Hide resolved
StefMa
StefMa reviewed Oct 7, 2024
View reviewed changes
library/build.gradle.kts Outdated Show resolved Hide resolved
StefMa
StefMa approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏
Thanks 🙃

@elmira-y elmira-y merged commit 70929ef into main Oct 7, 2024
8 checks passed
@elmira-y elmira-y deleted the suppress-ktor-r8-warning branch October 7, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefMa StefMa StefMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R8] Add proguard config for android releases
2 participants
@elmira-y @StefMa