WIP

ioki-mobility · Dec 1, 2021 · 5daf628 · 5daf628
1 parent efc11df
commit 5daf628
Show file tree

Hide file tree

Showing 20 changed files with 1,279 additions and 954 deletions.
diff --git a/lib/ioki/model/passenger/features.rb b/lib/ioki/model/passenger/features.rb
@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'ioki/model/passenger/minimum_age_confirmation'
+
 module Ioki
   module Model
     module Passenger
@@ -11,7 +13,7 @@ class Features < Ioki::Model::Base
         attribute :analytics_tracking, type: :boolean, on: :read
         attribute :failed_payment_handling, type: :boolean, on: :read
         attribute :marketing_automation, type: :boolean, on: :read
-        attribute :minimum_age_confirmation, type: :boolean, on: :read
+        attribute :minimum_age_confirmation, type: :object, on: :read, model_class: MinimumAgeConfirmation
         attribute :newsletter, type: :boolean, on: :read
         attribute :non_purchasable_personal_discounts, type: :boolean, on: :read
         attribute :payment, type: :boolean, on: :read

diff --git a/lib/ioki/model/passenger/minimum_age_confirmation.rb b/lib/ioki/model/passenger/minimum_age_confirmation.rb
@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Ioki
+  module Model
+    module Passenger
+      class MinimumAgeConfirmation < Ioki::Model::Base
+        # Note that this does not inherit from Base because it does not define :id, :type, :created_at and :updated_at.
+
+        unvalidated true # No specification available.
+
+        attribute :minimum_age, on: :read, type: :integer
+      end
+    end
+  end
+end
diff --git a/lib/ioki/model/passenger/ride_inquiry.rb b/lib/ioki/model/passenger/ride_inquiry.rb
@@ -12,6 +12,7 @@ module Passenger
       class RideInquiry < Base
         attribute :origin,         type: :object,  on: :create, model_class: RequestedPoint, unvalidated: true # The model does not return it but it's used when sending data to the server.
         attribute :destination,    type: :object,  on: :create, model_class: RequestedPoint, unvalidated: true # The model does not return it but it's used when sending data to the server.
+        attribute :product_id,     type: :string,  on: :create, unvalidated: true # The model does not return it but it's used when sending data to the server.
         attribute :assistances, on: :read, type: :array, model_class: Assistance
         attribute :availability, on: :read, type: :object, model_class: Availability
         attribute :constraints, on: :read, type: :object, model_class: Constraints

diff --git a/...endpoint/models_accessible_on_the_client_endpoint/has_data_for_all_defined_attributes.yml b/...endpoint/models_accessible_on_the_client_endpoint/has_data_for_all_defined_attributes.yml
diff --git a/...on_the_product_endpoint/Ioki_Model_Passenger_Area/has_data_for_all_defined_attributes.yml b/...on_the_product_endpoint/Ioki_Model_Passenger_Area/has_data_for_all_defined_attributes.yml
diff --git a/...product_endpoint/Ioki_Model_Passenger_BoundingBox/has_data_for_all_defined_attributes.yml b/...product_endpoint/Ioki_Model_Passenger_BoundingBox/has_data_for_all_defined_attributes.yml
diff --git a/...roduct_endpoint/Ioki_Model_Passenger_ImageVersion/has_data_for_all_defined_attributes.yml b/...roduct_endpoint/Ioki_Model_Passenger_ImageVersion/has_data_for_all_defined_attributes.yml
diff --git a/...product_endpoint/Ioki_Model_Passenger_RideOptions/has_data_for_all_defined_attributes.yml b/...product_endpoint/Ioki_Model_Passenger_RideOptions/has_data_for_all_defined_attributes.yml
diff --git a/...he_product_endpoint/Ioki_Model_Passenger_Timezone/has_data_for_all_defined_attributes.yml b/...he_product_endpoint/Ioki_Model_Passenger_Timezone/has_data_for_all_defined_attributes.yml
diff --git a/...s_accessible_on_the_ride_inqury_creation_endpoint/has_data_for_all_defined_attributes.yml b/...s_accessible_on_the_ride_inqury_creation_endpoint/has_data_for_all_defined_attributes.yml
diff --git a/...nger_api_models/Product_endpoint/models_accessible_on_the_rides_endpoint/cancellation.yml b/...nger_api_models/Product_endpoint/models_accessible_on_the_rides_endpoint/cancellation.yml
diff --git a/..._endpoint/models_accessible_on_the_rides_endpoint/has_data_for_all_defined_attributes.yml b/..._endpoint/models_accessible_on_the_rides_endpoint/has_data_for_all_defined_attributes.yml
diff --git a/..._on_the_product_endpoint/Ioki_Model_Platform_Area/has_data_for_all_defined_attributes.yml b/..._on_the_product_endpoint/Ioki_Model_Platform_Area/has_data_for_all_defined_attributes.yml
diff --git a/..._product_endpoint/Ioki_Model_Platform_BoundingBox/has_data_for_all_defined_attributes.yml b/..._product_endpoint/Ioki_Model_Platform_BoundingBox/has_data_for_all_defined_attributes.yml
diff --git a/..._product_endpoint/Ioki_Model_Platform_RideOptions/has_data_for_all_defined_attributes.yml b/..._product_endpoint/Ioki_Model_Platform_RideOptions/has_data_for_all_defined_attributes.yml
diff --git a/...the_product_endpoint/Ioki_Model_Platform_Timezone/has_data_for_all_defined_attributes.yml b/...the_product_endpoint/Ioki_Model_Platform_Timezone/has_data_for_all_defined_attributes.yml
diff --git a/...models/models_accessible_on_the_provider_endpoint/has_data_for_all_defined_attributes.yml b/...models/models_accessible_on_the_provider_endpoint/has_data_for_all_defined_attributes.yml
diff --git a/...s_accessible_on_the_ride_inqury_creation_endpoint/has_data_for_all_defined_attributes.yml b/...s_accessible_on_the_ride_inqury_creation_endpoint/has_data_for_all_defined_attributes.yml
diff --git a/...pi_models/models_accessible_on_the_rides_endpoint/has_data_for_all_defined_attributes.yml b/...pi_models/models_accessible_on_the_rides_endpoint/has_data_for_all_defined_attributes.yml
diff --git a/spec/ioki/model/models_without_open_api_specifications_spec.rb b/spec/ioki/model/models_without_open_api_specifications_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe 'models without open api specifications', vcr: { record: :all } do
+RSpec.describe 'models without open api specifications', :vcr do
   describe 'platform_api models' do
     setup_platform_client(:platform_client)
     let(:product) { platform_client.products.first }
@@ -89,7 +89,7 @@
     before do
       passenger_client.config.api_token = platform_client.create_request_token(
         platform_client.providers.first,
-        platform_client.users(platform_client.providers.first).first,
+        platform_client.users(platform_client.providers.first).last,
         Ioki::Model::Platform::PassengerRequestToken.new(
           client_identifier: 'dev.passengerapi.test.backend'
         )
@@ -159,45 +159,53 @@
         it 'has data for all defined attributes' do
           expect(passenger_client.rides(product).first.route).to be_a(Ioki::Model::Passenger::Route)
           expect(passenger_client.rides(product).first.route.track).to be_a(String)
+          pending('Needs a ride with a ticket that has a ticket with mobile_ticket_data')
           expect(passenger_client.rides(product).first.ticket.mobile_ticket_data).to be_a(Ioki::Model::Passenger::MobileTicketData)
-          pending('Needs a ride with a ticket that has mobile_ticket_data')
           expect(passenger_client.rides(product).first.ticket.mobile_ticket_data.purchase_id).to be_a(String)
           expect(passenger_client.rides(product).first.ticket.mobile_ticket_data.customer_code).to be_a(String)
         end
 
         it 'cancellation' do
-          pending('cancellation.rb -> cancel outgoing model only')
+          skip('cancellation.rb -> cancel outgoing model only')
         end
       end
 
       describe 'models accessible on the ride_inqury creation endpoint' do
         let(:ride_inqury) do
-          Ioki::Model::Passenger::RideInquiry.new(origin: { lat: 1, lng: 1 }, destination: { lat: 1, lng: 1 })
+          Ioki::Model::Passenger::RideInquiry.new(
+            origin:      { lat: 1, lng: 1 },
+            destination: { lat: 1, lng: 1 },
+            product_id:  product.id
+          )
         end
 
         it 'has data for all defined attributes' do
-          returned_ride_inquiry = passenger_client.create_ride_inquiry(product, ride_inqury)
+          returned_ride_inquiry = passenger_client.create_ride_inquiry(ride_inqury)
           expect(returned_ride_inquiry.availability).to be_a(Ioki::Model::Passenger::Availability)
           expect(returned_ride_inquiry.constraints).to be_a(Ioki::Model::Passenger::Constraints)
         end
       end
 
       describe 'models accessible on the client endpoint' do
         it 'has data for all defined attributes' do
-          expect(passenger_client.bootstrap.client.features).to be_a(Ioki::Model::Passenger::Features)
-          expect(passenger_client.bootstrap.client.features.analytics_tracking).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.failed_payment_handling).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.marketing_automation).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.minimum_age_confirmation).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.newsletter).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.non_purchasable_personal_discounts).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.payment).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.promo_codes).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.purchasable_personal_discounts).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.referrals).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.service_credits).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.unique_customer_id).to be(true).or(be(false))
-          expect(passenger_client.bootstrap.client.features.user_email_required).to be(true).or(be(false))
+          features = passenger_client.bootstrap.client.features
+
+          expect(features).to be_a(Ioki::Model::Passenger::Features)
+          expect(features.analytics_tracking).to be(true).or(be(false))
+          expect(features.failed_payment_handling).to be(true).or(be(false))
+          expect(features.marketing_automation).to be(true).or(be(false))
+          pending('Needs a client with a minimum_age_confirmation feature enabled')
+          expect(features.minimum_age_confirmation).to be_a(Ioki::Model::Passenger::MinimumAgeConfirmation)
+          expect(features.minimum_age_confirmation.minimum_age).to be_a(Integer)
+          expect(features.newsletter).to be(true).or(be(false))
+          expect(features.non_purchasable_personal_discounts).to be(true).or(be(false))
+          expect(features.payment).to be(true).or(be(false))
+          expect(features.promo_codes).to be(true).or(be(false))
+          expect(features.purchasable_personal_discounts).to be(true).or(be(false))
+          expect(features.referrals).to be(true).or(be(false))
+          expect(features.service_credits).to be(true).or(be(false))
+          expect(features.unique_customer_id).to be(true).or(be(false))
+          expect(features.user_email_required).to be(true).or(be(false))
         end
       end
     end