Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: no longer create the iob_npm.done file #2908

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

foxriver76
Copy link
Collaborator

Link the issue which is closed by this PR

It came up that the iob_npm.done file was checked in in repos in the past. This lead us into investigating and it seems that this file does not serve any purpose anymore.

Implementation details

Simply no longer create the file

Tests

  • I have added tests to avoid a recursion of this bug
  • It is not possible to test for this bug

If no tests added, please specify why it was not possible

nothing to test here

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 12, 2024

Check at github did only match

  • .gitignore entries
  • entries related to checking the file (repochecker, repository check)
  • js-controller code creating the file

see https://github.com/search?q=iob_npm.done&type=code&p=1

@foxriver76 foxriver76 merged commit 4149909 into master Sep 19, 2024
12 checks passed
@foxriver76 foxriver76 deleted the remove-npm-done branch September 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants