Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: automatically upload adapter on start if the upload is missing for some reason #2902

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

foxriver76
Copy link
Collaborator

Link the feature issue which is closed by this PR

In #2897 it was recommended to inform about missing uploads with a TODO to perform the upload automatically. To do this before start the code needs to move outside of the adapter class to also have correct information for blocked checks, dependency checks etc. (in general access to the current installed io-package and instance object).

Implementation details

During the adapter start checks we read the io-package.json and check if the version in the instance object differs. This should be a sufficient heuristic to detect failed uploads in most cases. If there is a difference, the adapter will be uploaded before any further checks will be performed.

Tests

  • I have added tests to test this feature
  • It is not possible to test this feature

Documentation

  • I have documented the new feature

There is a log line added to show what is going on. From my pov no need to document the feature.

If no tests added, please specify why it was not possible

Would need an adapter.

Copy link
Contributor

@GermanBluefox GermanBluefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foxriver76 foxriver76 merged commit 9a3639a into master Sep 12, 2024
12 checks passed
@foxriver76 foxriver76 deleted the fix-upload-problem branch September 12, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants