The ESM problem - executing the controller itself as an ESM module (#…

…2681)

* ts port of cliMessage

* port cliPlugin to ts

* port cli process

* improve arr filter typing

* for reinstall remove the package manually first

- closes #2667

* started working on the notorious ESM problem

* further work on porting to esm

* more work towards full esm

* fix lint

* make build work

* rm ts-expect-error

* fix types in tests

* fix adapter and add nvmrc, fix tests not starting

* own implementation of get-spdx-license-ids to get rid of request module

* log the stack on installation broken as these are often deeper issues

* added missing file extension

* get rid of requires in hasServer functions

* fix parsing cli args in adapter

- e.g. mocha passes arguments to the process, we now parsing them more accurate

* update testing

* optimize things found during own review

* try to increase timeout for file like done for redis in past

* update mocha

* register tests in nona sync fashion (try to fix problem that states jsonl tests not run on ci)

.eslintrc.json

@@ -7,7 +7,9 @@
     "eslint:recommended",
     "plugin:prettier/recommended"
   ],
-  "plugins": [],
+  "plugins": [
+    "unicorn"
+  ],
   "ignorePatterns": [
     "**/doc",
     "**/build"
@@ -72,10 +74,13 @@
     "no-trailing-spaces": "error",
     "prettier/prettier": "error",
     "no-nested-ternary": "off",
-    "no-unneeded-ternary": "error"
+    "no-unneeded-ternary": "error",
+    "unicorn/prefer-module": "error",
+    "unicorn/prefer-node-protocol": "error"
   },
   "parserOptions": {
-    "ecmaVersion": 2021
+    "sourceType": "module",
+    "ecmaVersion": 2022
   },
   "overrides": [
     {
@@ -87,6 +92,8 @@
       },
       "files": [
         "**/*.ts",
+        "**/*.cts",
+        "**/*.mts",
         "**/*.tsx"
       ],
       "extends": [

.github/workflows/ci-tests.yml

@@ -25,10 +25,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 16
+      - name: Use Node.js 18
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: NPM install
         run: npm i --ignore-scripts # install typescript and @types do not `setup first`
@@ -43,7 +43,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [windows-latest, ubuntu-20.04, macos-latest]
-        node: [16, 18, 20]
+        node: [18, 20]
 
     steps:
       - uses: actions/checkout@v4
@@ -124,11 +124,11 @@ jobs:
         if: steps.automerge.outputs.mergeResult == 'merged'
         uses: actions/checkout@v4
 
-      - name: Use Node.js 16
+      - name: Use Node.js 18
         if: steps.automerge.outputs.mergeResult == 'merged'
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Determine version
         if: steps.automerge.outputs.mergeResult == 'merged'

.github/workflows/nightly-dev-release.yml

@@ -11,7 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        node: [16.x] # This should be LTS
+        node: [18.x] # This should be LTS
 
     steps:
     - name: Checkout code

.github/workflows/official-release.yml

@@ -19,7 +19,7 @@ jobs:
 
     strategy:
       matrix:
-        node: [16.x] # This should be LTS
+        node: [18.x] # This should be LTS
 
     steps:
       - name: Checkout code

.mocharc.json

@@ -0,0 +1,3 @@
+{
+  "loader": "ts-node/esm"
+}

.nvmrc

@@ -0,0 +1 @@
+18