Clean up XML template files #23
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,165 +1,165 @@ | ||
| <rsm:CrossIndustryInvoice xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100" xmlns:ram="urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100" xmlns:rsm="urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100" xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <rsm:ExchangedDocumentContext> | ||
| <ram:BusinessProcessSpecifiedDocumentContextParameter> | ||
| <ram:ID/> | ||
| </ram:BusinessProcessSpecifiedDocumentContextParameter> | ||
| <ram:GuidelineSpecifiedDocumentContextParameter> | ||
| <ram:ID>urn:factur-x.eu:1p0:basic</ram:ID> | ||
| </ram:GuidelineSpecifiedDocumentContextParameter> | ||
| </rsm:ExchangedDocumentContext> | ||
| <rsm:ExchangedDocument> | ||
| <ram:ID/> | ||
| <ram:TypeCode>0</ram:TypeCode> | ||
| <ram:IssueDateTime> | ||
| <udt:DateTimeString format="102">00000000</udt:DateTimeString> | ||
|
There was a problem hiding this comment. Why so many 00 and not an empty tag? There was a problem hiding this comment. Because dates have 8 digits? There was a problem hiding this comment. Why not use an empty tag, like you did with all other tags? You said that's good practice. Why add placeholders for this one? |
||
| </ram:IssueDateTime> | ||
| <ram:IncludedNote> | ||
| <ram:Content/> | ||
| <ram:SubjectCode/> | ||
| </ram:IncludedNote> | ||
| <ram:IncludedNote> | ||
| <ram:Content/> | ||
| <ram:SubjectCode/> | ||
| </ram:IncludedNote> | ||
| <ram:IncludedNote> | ||
| <ram:Content/> | ||
| <ram:SubjectCode/> | ||
| </ram:IncludedNote> | ||
| <ram:IncludedNote> | ||
| <ram:Content/> | ||
| <ram:SubjectCode/> | ||
| </ram:IncludedNote> | ||
| <ram:IncludedNote> | ||
| <ram:Content/> | ||
| <ram:SubjectCode/> | ||
| </ram:IncludedNote> | ||
| </rsm:ExchangedDocument> | ||
| <rsm:SupplyChainTradeTransaction> | ||
| <ram:IncludedSupplyChainTradeLineItem> | ||
| <ram:AssociatedDocumentLineDocument> | ||
| <ram:LineID>0</ram:LineID> | ||
|
There was a problem hiding this comment. This can't be 0. It's the line numbering. |
||
| </ram:AssociatedDocumentLineDocument> | ||
| <ram:SpecifiedTradeProduct> | ||
| <ram:GlobalID schemeID="0160">0</ram:GlobalID> | ||
| <ram:Name/> | ||
| </ram:SpecifiedTradeProduct> | ||
| <ram:SpecifiedLineTradeAgreement> | ||
| <ram:NetPriceProductTradePrice> | ||
| <ram:ChargeAmount currencyID="EUR">0.0</ram:ChargeAmount> | ||
| </ram:NetPriceProductTradePrice> | ||
| </ram:SpecifiedLineTradeAgreement> | ||
| <ram:SpecifiedLineTradeDelivery> | ||
| <ram:BilledQuantity unitCode="PCE">0</ram:BilledQuantity> | ||
| </ram:SpecifiedLineTradeDelivery> | ||
| <ram:SpecifiedLineTradeSettlement> | ||
| <ram:ApplicableTradeTax> | ||
| <ram:TypeCode/> | ||
| <ram:CategoryCode/> | ||
| <ram:RateApplicablePercent>0</ram:RateApplicablePercent> | ||
| </ram:ApplicableTradeTax> | ||
| <ram:SpecifiedTradeSettlementLineMonetarySummation> | ||
| <ram:LineTotalAmount currencyID="EUR">0.0</ram:LineTotalAmount> | ||
| </ram:SpecifiedTradeSettlementLineMonetarySummation> | ||
| </ram:SpecifiedLineTradeSettlement> | ||
| </ram:IncludedSupplyChainTradeLineItem> | ||
| <ram:ApplicableHeaderTradeAgreement> | ||
| <ram:BuyerReference/> | ||
| <ram:SellerTradeParty> | ||
| <ram:ID schemeID="0002">0</ram:ID> | ||
| <ram:GlobalID schemeID="0002">0</ram:GlobalID> | ||
| <ram:Name/> | ||
| <ram:SpecifiedLegalOrganization> | ||
| <ram:ID schemeID="0002">0</ram:ID> | ||
| </ram:SpecifiedLegalOrganization> | ||
| <ram:PostalTradeAddress> | ||
| <ram:PostcodeCode>0</ram:PostcodeCode> | ||
| <ram:LineOne/> | ||
| <ram:CityName/> | ||
| <ram:CountryID/> | ||
| </ram:PostalTradeAddress> | ||
| <ram:URIUniversalCommunication> | ||
| <ram:URIID schemeID="SMTP">[email protected]</ram:URIID> | ||
| </ram:URIUniversalCommunication> | ||
| <ram:SpecifiedTaxRegistration> | ||
| <ram:ID schemeID="VA"/> | ||
| </ram:SpecifiedTaxRegistration> | ||
| </ram:SellerTradeParty> | ||
| <ram:BuyerTradeParty> | ||
| <ram:ID schemeID="0002">0</ram:ID> | ||
| <ram:Name/> | ||
| <ram:SpecifiedLegalOrganization> | ||
| <ram:ID schemeID="0002">0</ram:ID> | ||
| </ram:SpecifiedLegalOrganization> | ||
| <ram:PostalTradeAddress> | ||
| <ram:PostcodeCode>0</ram:PostcodeCode> | ||
| <ram:LineOne/> | ||
|
There was a problem hiding this comment. How did you decide on using an empty tag vs. |
||
| <ram:CityName/> | ||
| <ram:CountryID/> | ||
| </ram:PostalTradeAddress> | ||
| <ram:SpecifiedTaxRegistration> | ||
| <ram:ID schemeID="VA"/> | ||
| </ram:SpecifiedTaxRegistration> | ||
| </ram:BuyerTradeParty> | ||
| <ram:BuyerOrderReferencedDocument> | ||
| <ram:IssuerAssignedID/> | ||
| </ram:BuyerOrderReferencedDocument> | ||
| <ram:ContractReferencedDocument> | ||
| <ram:IssuerAssignedID/> | ||
| </ram:ContractReferencedDocument> | ||
| </ram:ApplicableHeaderTradeAgreement> | ||
| <ram:ApplicableHeaderTradeDelivery> | ||
| <ram:ActualDeliverySupplyChainEvent> | ||
| <ram:OccurrenceDateTime> | ||
| <udt:DateTimeString format="102">00000000</udt:DateTimeString> | ||
| </ram:OccurrenceDateTime> | ||
| </ram:ActualDeliverySupplyChainEvent> | ||
| <ram:DespatchAdviceReferencedDocument> | ||
| <ram:IssuerAssignedID/> | ||
| </ram:DespatchAdviceReferencedDocument> | ||
| </ram:ApplicableHeaderTradeDelivery> | ||
| <ram:ApplicableHeaderTradeSettlement> | ||
| <ram:InvoiceCurrencyCode/> | ||
| <ram:SpecifiedTradeSettlementPaymentMeans> | ||
| <ram:TypeCode>0</ram:TypeCode> | ||
| <ram:PayeePartyCreditorFinancialAccount> | ||
| <ram:IBANID/> | ||
| </ram:PayeePartyCreditorFinancialAccount> | ||
| </ram:SpecifiedTradeSettlementPaymentMeans> | ||
| <ram:ApplicableTradeTax> | ||
| <ram:CalculatedAmount currencyID="EUR">0.0</ram:CalculatedAmount> | ||
| <ram:TypeCode/> | ||
| <ram:BasisAmount currencyID="EUR">0.0</ram:BasisAmount> | ||
| <ram:CategoryCode/> | ||
| <ram:DueDateTypeCode>0</ram:DueDateTypeCode> | ||
| <ram:RateApplicablePercent>0</ram:RateApplicablePercent> | ||
| </ram:ApplicableTradeTax> | ||
| <ram:SpecifiedTradeAllowanceCharge> | ||
| <ram:ChargeIndicator> | ||
| <udt:Indicator/> | ||
| </ram:ChargeIndicator> | ||
| <ram:CalculationPercent>0.0</ram:CalculationPercent> | ||
| <ram:BasisAmount currencyID="EUR">0.0</ram:BasisAmount> | ||
| <ram:ActualAmount currencyID="EUR">0.0</ram:ActualAmount> | ||
| <ram:Reason/> | ||
| <ram:CategoryTradeTax> | ||
| <ram:TypeCode/> | ||
| <ram:CategoryCode/> | ||
| <ram:DueDateTypeCode>0</ram:DueDateTypeCode> | ||
| <ram:RateApplicablePercent>0</ram:RateApplicablePercent> | ||
| </ram:CategoryTradeTax> | ||
| </ram:SpecifiedTradeAllowanceCharge> | ||
| <ram:SpecifiedTradePaymentTerms> | ||
| <ram:DueDateDateTime> | ||
| <udt:DateTimeString format="102">00000000</udt:DateTimeString> | ||
| </ram:DueDateDateTime> | ||
| </ram:SpecifiedTradePaymentTerms> | ||
| <ram:SpecifiedTradeSettlementHeaderMonetarySummation> | ||
| <ram:LineTotalAmount currencyID="EUR">0.0</ram:LineTotalAmount> | ||
| <ram:AllowanceTotalAmount currencyID="EUR">0.0</ram:AllowanceTotalAmount> | ||
| <ram:TaxBasisTotalAmount currencyID="EUR">0.0</ram:TaxBasisTotalAmount> | ||
| <ram:TaxTotalAmount currencyID="EUR">0.0</ram:TaxTotalAmount> | ||
| <ram:GrandTotalAmount currencyID="EUR">0.0</ram:GrandTotalAmount> | ||
| <ram:DuePayableAmount currencyID="EUR">0.0</ram:DuePayableAmount> | ||
| </ram:SpecifiedTradeSettlementHeaderMonetarySummation> | ||
| </ram:ApplicableHeaderTradeSettlement> | ||
| </rsm:SupplyChainTradeTransaction> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will lxml expand the tag again? I would have expected to see
<ram:ID></ram:ID>for an empty tag.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the tags are expanded when any data is added. It's good practice to have empty tags as
<tag/>rather than<tag></tag>.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are expanded it's fine.