Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create duplicate detection GitHub Action #230

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Create duplicate detection GitHub Action #230

merged 4 commits into from
Jul 23, 2024

Conversation

webb-ben
Copy link
Member

@webb-ben webb-ben commented Jul 1, 2024

No description provided.

@webb-ben webb-ben requested a review from adplincinst July 2, 2024 18:44
Copy link

@adplincinst adplincinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @webb-ben . What I'm seeing is a new github action in this repo that runs the new yourls-action validate subcommnd to detect duplicate pids in a single file or collection of files within a directory (in gh action case the 'namespaces' directory). I notice though that the PIDS (i.e. urls) are not normalized/standardized and the comparisions are lexical/string based. So I can imagine a scenario (maybe improbable but possibly not) where there is a pid that is http://example.org/mypid1 and another that is http://example.org//mypid1 and another that is http://example.org/MyPID1 . These are all the same URL (I believe caps do not matter per RFC) yet if you do string comparison operation they are distinct.

@webb-ben
Copy link
Member Author

webb-ben commented Jul 3, 2024

Note the PID service does maintain capital letters in redirects.

See https://geoconnex.us/iow/map (recorded PID)
and https://geoconnex.us/iow/Map (nonexistent PID)

@webb-ben webb-ben merged commit ef4e235 into master Jul 23, 2024
1 check passed
@webb-ben webb-ben deleted the bw-dup branch July 23, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants