refactor(ConnectWalletForm): preserve key in errors

[sidvishnoi]

Earlier, we stored only localized message in errors[foo]. Now we preserve the key and original error under {info}; and add the localized message under {message}.

This will help with error handling based on key, and paves way to support retry add-key on retry-able errors (such as timed out waiting for login, wrong account was logged in, key-add consent accidentally declined etc.)

Part of #613

[github-actions]

Extension builds preview

Name	Link
Latest commit	15a52f2
Latest job logs	Run #11177902310
	Download
	Download

[raducristianpopa]

Why do we have the error as string as well? Can't we pass the whole error directly? For example here:

web-monetization-extension/src/popup/components/ConnectWalletForm.tsx

Lines 114 to 124 in a012ce4

	try {
	setIsValidating((_) => ({ ..._, walletAddressUrl: true }));
	const url = new URL(toWalletAddressUrl(walletAddressUrl));
	const walletAddress = await getWalletInfo(url.toString());
	setWalletAddressInfo(walletAddress);
	} catch (error) {
	setErrors((_) => ({
	..._,
	walletAddressUrl: toErrorInfo(error.message),
	}));
	return false;

[sidvishnoi]

If we allow passing { message: string } (which matches Error), we've to always add a check for isErrorWithKey, which is more expensive then typeof err === 'string'.

I'll look into rationalizing error types as a follow-up. I basically want only Error ({ messsage: string }) and ErrorWithKeyLike, with failure or ErrorResponse allowing returning serialization of either.

[raducristianpopa]

We are mixing errors as exceptions and errors as value with the validateWalletAddressUrl and validateAmount. Not a big fan, but I understand why this approach.

It might be worth looking into neverthrow later on.