Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): improve warning message for non-monetized tabs #624

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Sep 25, 2024

Context

Closes #584

Changes proposed in this pull request

  • Add copy for different not-monetized reasons (tab.status)
  • Remove components SiteNotMonetized, AllSessionsInvalid
  • Add generic NotMonetized component, with minor style changes to make it look better for all messages.

@github-actions github-actions bot added area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests area: i18n labels Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Extension builds preview

Name Link
Latest commit 9e78bf5
Latest job logs Run #11045037707
BadgeDownload
BadgeDownload

src/_locales/en/messages.json Outdated Show resolved Hide resolved
src/_locales/en/messages.json Outdated Show resolved Hide resolved
src/_locales/en/messages.json Outdated Show resolved Hide resolved
src/_locales/en/messages.json Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi marked this pull request as ready for review September 25, 2024 11:47
@sidvishnoi sidvishnoi merged commit 157fe5a into main Sep 26, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the not-monetized-messages branch September 26, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: i18n area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Show msg that WM ext only supports HTTPS sites
2 participants