Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(background): if wallet not connected, display default icon #506

Merged
merged 4 commits into from
Aug 16, 2024
Merged

fix(background): if wallet not connected, display default icon #506

merged 4 commits into from
Aug 16, 2024

Conversation

dianafulga
Copy link
Contributor

@dianafulga dianafulga commented Aug 16, 2024 •
edited by sidvishnoi
Loading

Fixes #505

@dianafulga dianafulga marked this pull request as ready for review August 16, 2024 10:05
@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Aug 16, 2024
@dianafulga dianafulga changed the title If not connected, display default icon [Fix]: If not connected, display default icon Aug 16, 2024
@dianafulga dianafulga changed the title [Fix]: If not connected, display default icon Fix[background]: If not connected, display default icon Aug 16, 2024
@dianafulga dianafulga changed the title Fix[background]: If not connected, display default icon Fix(background): If not connected, display default icon Aug 16, 2024
@dianafulga dianafulga changed the title Fix(background): If not connected, display default icon Fix(background): If wallet not connected, display default icon Aug 16, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Aug 16, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit b99a888
Latest job logs Run #10419602797
BadgeDownload
BadgeDownload

@dianafulga dianafulga changed the title Fix(background): If wallet not connected, display default icon fix(background): If wallet not connected, display default icon Aug 16, 2024
@sidvishnoi sidvishnoi changed the title fix(background): If wallet not connected, display default icon fix(background): if wallet not connected, display default icon Aug 16, 2024
sidvishnoi
sidvishnoi approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dianafulga!

@raducristianpopa raducristianpopa merged commit 708838e into main Aug 16, 2024
8 checks passed
@raducristianpopa raducristianpopa deleted the df--bug-default-icon branch August 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Default icon should be displayed if wallet is not connected
3 participants
@dianafulga @raducristianpopa @sidvishnoi