Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update workflows #35

Merged
merged 20 commits into from
Dec 11, 2023
Merged

chore(ci): update workflows #35

merged 20 commits into from
Dec 11, 2023

Conversation

raducristianpopa
Copy link
Member

@raducristianpopa raducristianpopa commented Dec 5, 2023

Closes #22.

This PR updates the current workflow files and adds a couple of new ones:

  • sanity - will be triggered whenever we push on the main branch

    • currently only builds the extension for all browsers
    • will need to add linting and testing as well to make sure that everything works accordingly after a merge
  • pr-checks - will be triggered whenever a new PR is created

    • builds the extension for all browser and uploads all the ZIP files as artifacts
    • needs linting + testing as well
    • concurrency (when pushing a new commit, previous running actions will be cancelled)
  • build-previews - will be triggered when the pr-checks workflow is finished (on success or failure - the status does not matter)

    • retrieves the latest PR artifacts and adds a comment with a table (or it updates the existing one) with:
      • latest commit SHA
      • latest job logs URL
      • all ZIP files download URL (for all browsers) which contains the build status and the ZIP size
      • it will not add/update the comment with the builds preview if the pr-checks action gets cancelled
  • delete-pr-artifacts - will be triggered when a PR is closed

    • deletes all uploaded artifacts for this specific PR (all builds preview)

Concerns

The build-previews workflow might not be triggered when a PR is made from a fork (still needs a bit of research). The primary goal was to ensure that the previews are available for us when we create a PR, allowing us to test all the changes.


The comment with all the links will be added when the workflow will be in the main branch, that's why for this PR the build previews are not available.

Comment preview image

@raducristianpopa raducristianpopa marked this pull request as ready for review December 6, 2023 12:51
@raducristianpopa raducristianpopa merged commit 23456a2 into main Dec 11, 2023
7 checks passed
@raducristianpopa raducristianpopa deleted the rp--pr-workflows branch December 11, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build on GitHub
2 participants