Breaking: Full support for websocket-based notifications and eol'ed http notifications

src/lib/app.js

@@ -16,8 +16,6 @@ const metadata = require('../controllers/metadata')
 const health = require('../controllers/health')
 const transfers = require('../controllers/transfers')
 const accounts = require('../controllers/accounts')
-const subscriptions = require('../controllers/subscriptions')
-const notifications = require('../controllers/notifications')
 const seedDB = require('./seed-db')
 const createTables = require('./db').createTables
 const readLookupTables = require('./db').readLookupTables
@@ -31,7 +29,7 @@ class App {
     this.config = modules.config
     this.db = modules.db
     this.timerWorker = modules.timerWorker
-    this.notificationWorker = modules.notificationWorker
+    this.notificationBroadcaster = modules.notificationBroadcaster
 
     const koaApp = this.koa = websockify(koa())
     const router = this._makeRouter()
@@ -64,7 +62,6 @@ class App {
     // Start timerWorker to trigger the transferExpiryMonitor
     // when transfers are going to expire
     yield this.timerWorker.start()
-    this.notificationWorker.start()
 
     if (this.config.getIn(['db', 'sync'])) {
       yield createTables()
@@ -143,23 +140,6 @@ class App {
       },
       accounts.putResource)
 
-    router.get('/subscriptions/:id',
-      passport.authenticate(['basic', 'http-signature', 'client-cert'], { session: false }),
-      subscriptions.getResource)
-    router.put('/subscriptions/:id',
-      passport.authenticate(['basic', 'http-signature', 'client-cert'], { session: false }),
-      function * (next) {
-        this.body = yield parseBody(this)
-        yield next
-      },
-      subscriptions.putResource)
-    router.delete('/subscriptions/:id',
-      passport.authenticate(['basic', 'http-signature', 'client-cert'], { session: false }),
-      subscriptions.deleteResource)
-
-    router.get('/subscriptions/:subscription_id/notifications/:notification_id',
-      passport.authenticate(['basic', 'http-signature', 'client-cert'], { session: false }),
-      notifications.getResource)
     return router
   }
 

src/lib/db.js

@@ -17,8 +17,6 @@ const TABLE_NAMES = [
   'L_ACCOUNTS',
   'L_FULFILLMENTS',
   'L_ENTRIES',
-  'L_NOTIFICATIONS',
-  'L_SUBSCRIPTIONS',
   'L_TRANSFERS',
   'L_LU_REJECTION_REASON',
   'L_LU_TRANSFER_STATUS'

src/lib/notificationBroadcasterWebsocket.js

@@ -0,0 +1,58 @@
+'use strict'
+
+const _ = require('lodash')
+const EventEmitter = require('events').EventEmitter
+const transferDictionary = require('five-bells-shared').TransferStateDictionary
+const transferStates = transferDictionary.transferStates
+const isTransferFinalized = require('./transferUtils').isTransferFinalized
+const convertToExternalTransfer = require('../models/converters/transfers')
+  .convertToExternalTransfer
+const getFulfillment = require('../models/db/fulfillments').getFulfillment
+const convertToExternalFulfillment = require('../models/converters/fulfillments')
+  .convertToExternalFulfillment
+
+class NotificationBroadcaster extends EventEmitter {
+  constructor (log) {
+    super()
+    this.log = log
+  }
+
+  * sendNotifications (transfer, transaction) {
+    const affectedAccounts = _([transfer.debits, transfer.credits])
+      .flatten().pluck('account').value()
+    affectedAccounts.push('*')
+
+    // Prepare notification for websocket subscribers
+    const notificationBody = {
+      resource: convertToExternalTransfer(transfer)
+    }
+
+    // If the transfer is finalized, see if it was finalized by a fulfillment
+    let fulfillment
+    if (isTransferFinalized(transfer)) {
+      fulfillment = yield getFulfillment(transfer.id, { transaction })
+
+      if (fulfillment) {
+        if (transfer.state === transferStates.TRANSFER_STATE_EXECUTED) {
+          notificationBody.related_resources = {
+            execution_condition_fulfillment:
+              convertToExternalFulfillment(fulfillment)
+          }
+        } else if (transfer.state === transferStates.TRANSFER_STATE_REJECTED) {
+          notificationBody.related_resources = {
+            cancellation_condition_fulfillment:
+              convertToExternalFulfillment(fulfillment)
+          }
+        }
+      }
+    }
+
+    this.log.debug('emitting transfer-{' + affectedAccounts.join(',') + '}')
+    for (let account of affectedAccounts) {
+      this.emit('transfer-' + account, notificationBody)
+    }
+  }
+
+}
+
+module.exports = NotificationBroadcaster