Update apps by reapplying the templates files #272
Conversation
|
Probably don't want the So if I understand/read correctly, this just leaves the erb output-ed files as-is and simply updates templates? Seems reasonable. |
|
Yes. The changes were previously available in a diff file. They will now be available with |
|
Sounds good |
|
I've rebased this branch to let the tests pass now that #273 is merged. |
lib/pliny/commands/updater.rb
Outdated
| require 'uri' | ||
|
|
||
| module Pliny::Commands | ||
| class Updater | ||
| class Updater < Creator |
There was a problem hiding this comment.
Inheriting from the Creator looks a little strange from me. Was there any specific decision to do this, other than avoid duplicating a few methods? My worry is that there might be unintended side effects by this if something changes in the Creator.
There was a problem hiding this comment.
I think I did this to avoid some code repetition. I'm fine removing it though, I just did so.
|
Thanks @dmathieu. This seems to fix an issue that I just got nudged about. I've added a comment on the change, but otherwise looks good to me. |
We need to apply ERB when updating, which cannot reliably be done with a diff content. Anyone updating can still check it's changes by inspecting the unstaged changed in their repository Closes #271
| @@ -1,6 +1,7 @@ | |||
| require 'fileutils' | |||
| require 'pathname' | |||
| require 'pliny/version' | |||
| require 'pliny/commands/creator' | |||
There was a problem hiding this comment.
I'm assuming this line is not needed anymore?
We need to apply ERB when updating, which cannot reliably be done with a diff content.
Anyone updating can still check it's changes by inspecting the unstaged changed in their repository.
cc @dmcinnes @geemus
Closes #271