-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add thread_name
field in the webhook field
#1722
Conversation
Should I add a check in the method to say |
Typically, input errors like this are just handled through |
I think the error report from the discord API for channel checking is enough along with the warnings in the docstring. It should be ready for review. |
I think this is good to be merged. Is there any further modification needed? |
Yeah, I'm happy with it |
Pull Request Type
Description
This enables the API to create thread in forum and media channels.
Changes
thread_name
field to theapi.http.http_requests.webhook.WebhookRequests.execute_webhook
method.thread_name
field to themodels.discord.webhook.Webhook.send
methodthread_name
andthread
Related Issues
#1721
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files