This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Modify docs2 #1898
Open
Modify docs2 #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2018 14:23
somehow missed on the first go around. Signed-off-by: Timothy Harvey <[email protected]>
aio.md and ble.md: each had their own version of ReadCallback, so they couldn't be compiled together; we changed the types to include the package name to uniquely identify each one buffer.md: Javascript objects have a method called toString, so changed the operation name to to_string; changed "Uint8" to the WebIDL type "octet"; set a default value for the to_string operation and specified it as "optional" to match the corresponding zephry code gpio.md and sensors.md: like aio/ble, these each declared their own version of "ChangeCallback", so we prepended each instance with its package name pme.md: set JSON to all caps, because that's the way that WebIDL defines it Signed-off-by: Timothy Harvey <[email protected]>
t-harvey
force-pushed
the
modify_docs2
branch
from
707d977
to
8e806e7
Compare
…fy_docs2 Signed-off-by: Timothy Harvey <[email protected]>
t-harvey
force-pushed
the
modify_docs2
branch
from
8e806e7
to
44464fd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my role of fixing the WebIDL in the documentation, I've made what should be the last of the changes to WebIDL inconsistencies:
aio.md and ble.md: each had their own version of ReadCallback, so they couldn't be compiled together; we changed the types to include the package name to uniquely identify each one
buffer.md: Javascript objects have a method called toString, so changed the operation name to to_string; changed "Uint8" to the WebIDL type "octet"; set a default value for the to_string operation and specified it as "optional" to match the corresponding zephyr code
gpio.md and sensors.md: like aio/ble, these each declared their own version of "ChangeCallback", so we prepended each instance with its package name
pme.md: set JSON to all caps, because that's the way that WebIDL defines it