Add aten::_thnn_fused_gru_cell and _thnn_fused_lstm_cell #926
+1,077
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wetitpig
reviewed
Nov 4, 2024
src/ATen/native/xpu/GRUFusedCell.cpp
Outdated
| #include <ATen/core/op_registration/adaption.h> | ||
| #include <ATen/native/cpu/mixed_data_type.h> | ||
| #include <ATen/native/xpu/sycl/GRUFusedCellKernels.h> | ||
| #include <ATen/xpu/XPUNativeFunctions.h> |
There was a problem hiding this comment.
This header file seems to be non-existent from the build logs.
Would changing to XPUFunctions.h instead of XPUNativeFunctions.h make it work?
majing921201
reviewed
Nov 6, 2024
| #include <ATen/core/op_registration/adaption.h> | ||
| #include <ATen/native/cpu/mixed_data_type.h> | ||
| #include <ATen/native/xpu/sycl/RNNKernels.h> | ||
|
|
There was a problem hiding this comment.
#include <ATen/core/op_registration/adaption.h>
#include <ATen/native/cpu/mixed_data_type.h>
please check if we need head files
|
|
||
| auto hy = at::empty_like(hx, LEGACY_CONTIGUOUS_MEMORY_FORMAT); | ||
|
|
||
| AT_DISPATCH_FLOATING_TYPES_AND2( |
There was a problem hiding this comment.
How we handle non-contiguous input ? CUDA uses tensorInfo, but we just use raw data pointer, without stride information
| const Tensor& hidden_bias = | ||
| c10::value_or_else(hidden_bias_opt, [] { return Tensor(); }); | ||
|
|
||
| auto batched_input = true; |
There was a problem hiding this comment.
If hard code true, can we remove it
yucai-intel
changed the title
|
@yucai-intel Pls show the testcase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_thnn_fused_gru_cell_forward
_thnn_fused_gru_cell_backward
_thnn_fused_lstm_cell_forward
_thnn_fused_lstm_cell_backward