Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aten::_ctc_loss and its variants #925

Merged
merged 18 commits into from
Oct 13, 2024
Merged

Add aten::_ctc_loss and its variants #925

merged 18 commits into from
Oct 13, 2024

Conversation

xytintel
Copy link
Contributor

@xytintel xytintel commented Sep 19, 2024 •
edited
Loading

  • _ctc_loss
  • _ctc_loss.Tensor
  • _ctc_loss_backward
  • _ctc_loss_backward.Tensor

dvrogozh
dvrogozh suggested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops should be excluded from here:

torch-xpu-ops/src/ATen/native/xpu/XPUFallback.template

Lines 169 to 170 in c134991

"_ctc_loss",
"_ctc_loss_backward",

and added to
https://github.com/intel/torch-xpu-ops/blob/main/yaml/xpu_functions.yaml

@dvrogozh dvrogozh mentioned this pull request Sep 19, 2024
Open
10 tasks
@xytintel xytintel marked this pull request as draft September 20, 2024 05:40
@xytintel xytintel added the kernel_ready dev status: kernel ready label Sep 24, 2024
@xytintel xytintel added this to the PT2.6 milestone Sep 24, 2024
@xytintel xytintel marked this pull request as ready for review September 25, 2024 02:42
@xytintel xytintel added the operator_ready dev status: operator ready label Sep 25, 2024
@xytintel xytintel marked this pull request as draft September 27, 2024 05:48
@xytintel xytintel marked this pull request as ready for review September 27, 2024 07:13
@xytintel xytintel removed kernel_ready dev status: kernel ready operator_ready dev status: operator ready labels Oct 11, 2024
@xytintel
Copy link
Contributor Author

image
image

@xytintel xytintel added this pull request to the merge queue Oct 13, 2024
Merged via the queue into main with commit 9094e43 Oct 13, 2024
3 checks passed
@xytintel xytintel deleted the xyt/ctc_loss branch October 13, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh requested changes

@ZhiweiYan-96 ZhiweiYan-96 ZhiweiYan-96 approved these changes

@fengyuan14 fengyuan14 Awaiting requested review from fengyuan14

@majing921201 majing921201 Awaiting requested review from majing921201

Assignees
No one assigned
Labels
xpu-op
Projects
None yet
Milestone
PT2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@xytintel @dvrogozh @ZhiweiYan-96 @fengyuan14