Improved some of the UT codes and cleaned the skip list. #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
PenghuiCheng
changed the title
Signed-off-by: Cheng Penghui <[email protected]>
Signed-off-by: Cheng Penghui <[email protected]>
fengyuan14
reviewed
Aug 26, 2024
| @@ -90,7 +90,7 @@ def fn_to_gradcheck(*flat_input_and_params): | |||
| @wrapSwapTensorsTest() | |||
| def _test_to(self, device, dtype, module_info, training, swap, set_grad): | |||
| module_cls = module_info.module_cls | |||
| devices = ['xpu'] | |||
| devices = ['cpu', 'xpu'] | |||
There was a problem hiding this comment.
What's the meaning of adding cpu to devices?
There was a problem hiding this comment.
the case is to compare cpu and xpu op output, we aligned with cuda. If didn't add "cpu" , the case will error.
There was a problem hiding this comment.
It is ok to align with cuda but why the test will fail if no cpu in the devices list?
There was a problem hiding this comment.
because the order of testing will affect the results
fengyuan14
reviewed
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved some of the UT codes and cleaned the skip list.