Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows Build #773

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add Windows Build #773

wants to merge 29 commits into from

Conversation

RUIJIEZHONG66166
Copy link
Contributor

No description provided.

chuanqi129
chuanqi129 reviewed Aug 23, 2024
View reviewed changes
.github/workflows/pull.yml Outdated
@@ -35,6 +35,13 @@ jobs:
abi: 0
ut: op_extended
runner: linux.idc.xpu

preci-windows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
preci-windows:
preci-windows-build:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/workflows/windows.yml Outdated
if: ${{ ! cancelled() }}
uses: actions/upload-artifact@v4
with:
name: Inductor-Windows-Binary-${{ github.event.pull_request.number || github.sha }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Inductor-Windows-Binary-${{ github.event.pull_request.number || github.sha }}
name: Torch-XPU-Windows-Binary-${{ github.event.pull_request.number || github.sha }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/workflows/windows.yml Outdated
exit /b 1
)
pip install --force-reinstall dist/*.whl
git clone https://github.com/pytorch/vision && cd vision && python setup.py install && cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove torchvision part in torch xpu build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/workflows/windows.yml Outdated
with:
name: Inductor-Windows-Binary-${{ github.event.pull_request.number || github.sha }}
path: ${{ github.workspace }}/../pytorch/dist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the last line without any space string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/scripts/install_oneapi_bundle.bat Outdated
REM To-do: Add driver installation in this file.

set ONEAPI_PARENT_DIR=C:\Program Files (x86)\Intel
set INTEL_ONEAPI_PYTORCH_BUNDLE_URL=https://registrationcenter-download.intel.com/akdlm/IRC_NAS/5ca2021d-dd1a-4ab1-bd52-758fe63cf827/w_intel-for-pytorch-gpu-dev_p_0.5.2.19_offline.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the bundle link to 0.5.3 and install pti also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the bundle link to 0.5.3. Then, I will try to add pti installation and sync with US val team about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need sync, just follow the latest BKC. Anyway, you can submit another PR for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just for effort saving. We do not need to do it for both side. I will also try to do it later with another PR for it.

.github/scripts/install_oneapi_bundle.bat Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to install_xpu.bat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

chuanqi129
chuanqi129 reviewed Aug 23, 2024
View reviewed changes
.github/workflows/windows.yml Outdated
VS2022INSTALLDIR: 'C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvarsall.bat'

jobs:
Torch-XPU-Windows-Tests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Torch-XPU-Windows-Tests:
Torch-XPU-Windows-Build:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chuanqi129
Copy link
Contributor

@RUIJIEZHONG66166 I have rebased the PR, please update the build scripts with below BKC

1. call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat" Or set VS2022INSTALLDIR=C:\Program Files\Microsoft Visual Studio\2022\Community
2. call "C:\Program Files (x86)\Intel\oneAPI\setvars.bat"
3. activate conda env, also can move this step before step 1.
4. set USE_KINETO=0
5. set CMAKE_SHARED_LINKER_FLAGS=/FORCE:MULTIPLE
6. set CMAKE_MODULE_LINKER_FLAGS=/FORCE:MULTIPLE
7. set CMAKE_EXE_LINKER_FLAGS=/FORCE:MULTIPLE
8. build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuanqi129 chuanqi129 chuanqi129 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RUIJIEZHONG66166 @chuanqi129