[PT2.6][Windows] Fix Windows Codegen #1057
Open
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EikanWang
reviewed
Nov 7, 2024
| execute_process(COMMAND cmd /c mklink /D ${LinkPATH} ${TargetPATH}) | ||
| string(REPLACE "/" "\\" DestPATH "${CODEGEN_TEMPLATE}templates") | ||
| string(REPLACE "/" "\\" SrcPATH "${CMAKE_SOURCE_DIR}/aten/src/ATen/templates") | ||
| execute_process(COMMAND cmd /c xcopy ${SrcPATH} ${DestPATH} /E /H /C /I /Y > nul) |
There was a problem hiding this comment.
@ratnampa , do you know why mklink did not impact the Windows build in the past?
There was a problem hiding this comment.
@EikanWang I am not sure why this wasn't an issue before, but seems that the admin privileges is the only issue. I have updated the code, it should pass CI, and copy should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running codegen on windows is running into below error recently,
FileNotFoundError: [Errno 2] No such file or directory: 'C:/Users/sdp/ratnam-work/pytorch/third_party/torch-xpu-ops/yaml/templates\\RegisterDispatchDefinitions.ini'This is caused due to this symlink command in windows not running a shell or cmd as an administrator
torch-xpu-ops/cmake/Codegen.cmake
Line 61 in b1582e1
Also, when symlink is not performed due to access issues, cmake throws such error:
You do not have sufficient privilege to perform this operation.Resolution
Change symlink to copy templates folder and delete it once codegen is complete.