Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip polygamma float16 test #1050

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Skip polygamma float16 test #1050

merged 3 commits into from
Nov 11, 2024

Conversation

Stonepia
Copy link
Contributor

@Stonepia Stonepia commented Nov 6, 2024

We skip the polygamma float16 test due to a CPU issue: pytorch/pytorch#132386

This issue is caused by that the CPU result is not the same with CUDA/XPU. We believe that it should be fixed from the CPU side.

We skip the polygamma float16 test due to a CPU issue:
pytorch/pytorch#132386
Copy link
Contributor

@daisyden daisyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a cpu case, it is ok to skip it.

@Stonepia
Copy link
Contributor Author

The CI failure is not because of this PR, thus could be merged:

024-11-08T13:14:30.6094569Z Traceback (most recent call last):
2024-11-08T13:14:30.6094901Z   File "<string>", line 1, in <module>
2024-11-08T13:14:30.6097688Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/multiprocessing/spawn.py", line 116, in spawn_main
2024-11-08T13:14:30.6098246Z     exitcode = _main(fd, parent_sentinel)
2024-11-08T13:14:30.6098731Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/multiprocessing/spawn.py", line 126, in _main
2024-11-08T13:14:30.6099255Z     self = reduction.pickle.load(from_parent)
2024-11-08T13:14:30.6106200Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/torch/utils/data/datapipes/datapipe.py", line 386, in __setstate__
2024-11-08T13:14:30.6107069Z     self._datapipe = dill.loads(value)
2024-11-08T13:14:30.6107662Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 301, in loads
2024-11-08T13:14:30.6108181Z     return load(file, ignore, **kwds)
2024-11-08T13:14:30.6108730Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 287, in load
2024-11-08T13:14:30.6109269Z     return Unpickler(file, ignore=ignore, **kwds).load()
2024-11-08T13:14:30.6109841Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 442, in load
2024-11-08T13:14:30.6110338Z     obj = StockUnpickler.load(self)
2024-11-08T13:14:30.6110908Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 432, in find_class
2024-11-08T13:14:30.6111441Z     return StockUnpickler.find_class(self, module, name)
2024-11-08T13:14:30.6112189Z   File "/home/sdp/actions-runner-1/_work/torch-xpu-ops/pytorch/third_party/torch-xpu-ops/test/xpu/test_dataloader_xpu.py", line 32, in <module>
2024-11-08T13:14:30.6112802Z     from test_dataloader import (
2024-11-08T13:14:30.6113781Z ImportError: cannot import name 'TestDataLoaderDeviceType' from 'test_dataloader' (/home/sdp/actions-runner-1/_work/torch-xpu-ops/pytorch/third_party/torch-xpu-ops/test/xpu/../../../../test/test_dataloader.py)
2024-11-08T13:14:30.7242166Z Traceback (most recent call last):
2024-11-08T13:14:30.7242638Z   File "<string>", line 1, in <module>
2024-11-08T13:14:30.7243179Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/multiprocessing/spawn.py", line 116, in spawn_main
2024-11-08T13:14:30.7243666Z     exitcode = _main(fd, parent_sentinel)
2024-11-08T13:14:30.7244137Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/multiprocessing/spawn.py", line 126, in _main
2024-11-08T13:14:30.7244620Z     self = reduction.pickle.load(from_parent)
2024-11-08T13:14:30.7245362Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/torch/utils/data/datapipes/datapipe.py", line 386, in __setstate__
2024-11-08T13:14:30.7245958Z     self._datapipe = dill.loads(value)
2024-11-08T13:14:30.7246499Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 301, in loads
2024-11-08T13:14:30.7246962Z     return load(file, ignore, **kwds)
2024-11-08T13:14:30.7247475Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 287, in load
2024-11-08T13:14:30.7248086Z     return Unpickler(file, ignore=ignore, **kwds).load()
2024-11-08T13:14:30.7248653Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 442, in load
2024-11-08T13:14:30.7249099Z     obj = StockUnpickler.load(self)
2024-11-08T13:14:30.7251032Z   File "/home/sdp/miniforge3/envs/xpu_op_1/lib/python3.10/site-packages/dill/_dill.py", line 432, in find_class
2024-11-08T13:14:30.7251565Z     return StockUnpickler.find_class(self, module, name)
2024-11-08T13:14:30.7252270Z   File "/home/sdp/actions-runner-1/_work/torch-xpu-ops/pytorch/third_party/torch-xpu-ops/test/xpu/test_dataloader_xpu.py", line 32, in <module>
2024-11-08T13:14:30.7252850Z     from test_dataloader import (
2024-11-08T13:14:30.7253704Z ImportError: cannot import name 'TestDataLoaderDeviceType' from 'test_dataloader' (/home/sdp/actions-runner-1/_work/torch-xpu-ops/pytorch/third_party/torch-xpu-ops/test/xpu/../../../../test/test_dataloader.py)

@Stonepia Stonepia merged commit 92bdb91 into main Nov 11, 2024
2 of 3 checks passed
@Stonepia Stonepia deleted the tongsu/skip_polygamma branch November 11, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants