This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
Fixes for customer issues on Release-july release #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'invariant' qualifier is propagated on variables which are used to calculate other invariant variables, however when we are matching variable's declarations we should take into account only explicitly declared invariance because invariance propagation is an implementation specific detail. Thus new flag is added to ir_variable_data which indicates 'invariant' qualifier being explicitly set in the shader. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100316 Signed-off-by: Danylo Piliaiev <[email protected]> Signed-off-by: Dongwon Kim <[email protected]>
validate the addresses after mapping batch and state buffers, and fail the submission if any of mapping failed. Signed-off-by: Xiong, James <[email protected]>
tpalli
reviewed
May 29, 2019
| state_map = brw_bo_map(brw, batch->state.bo, MAP_WRITE); | ||
| if (state_map == NULL) { | ||
| brw_bo_unmap(batch->batch.bo); | ||
| return -1; |
There was a problem hiding this comment.
Why would the mapping fail, what was the failing usecase/app?
There was a problem hiding this comment.
The problem happened only once and a core dump was the only thing the customer could provide, I found the the application tried to access a NULL pointer and triggered A/V. To answer your question: we don't know the root cause of the mapping failure,
This is simply a w/a to fail the submission in case of mapping failure, hopefully the user app checks the error and fails gracefully instead of crashes to terminal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic fixes for specific case for GLSL (patch #1) and Null ptr issue (patch #2)