-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use cveb.in mirror by default #3265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial run is still using --nvd json in https://github.com/intel/cve-bin-tool/blob/main/.github/workflows/testing.yml
For backwards compatibility, I think we should keep "json" as an option so as not to break people's scripts, but have it now mean the same as json-mirror (e.g. treat it like syntactic sugar). I suspect a lot of people use the --nvd json
option right now for update/cache refresh jobs and in CI environments where API/API2 were performing poorly.
Also, I'm excited that this is finally happening! 🎆 🍾 |
Codecov Report
@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 81.11% 80.95% -0.17%
==========================================
Files 716 724 +8
Lines 11114 11314 +200
Branches 1495 1532 +37
==========================================
+ Hits 9015 9159 +144
- Misses 1706 1743 +37
- Partials 393 412 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This looks good to go, but I'm going to wait 'till Monday to merge it so I'm actually at my computer more frequently if we start seeing weirdness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think we're good to go. I'm going to enable this and we'll see if anything misbehaves over the next few days.
part of #3181