-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering and Identifying Transfer Events in Enclave #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, in general it looks simple and easy! I have only some minor comments. :)
@@ -0,0 +1,6 @@ | |||
## Test transfer from Alice to random account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For an intermediate solution, I shall accept the js-stuff, but I would like to stay consistent and only use our shell-rust integration tests. Also because what you implemented here is already possible with our current rust-cli.
I do think, however, that when we want to extend our integration testing suite, that a switch to js/ts is reasonable, but then with a holistic approach. :)
# Conflicts: # Cargo.lock # enclave-runtime/Cargo.lock
09556cc
to
11ed34b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good, I have two minor suggestions, which I will quickly fix myself.
Addresses first bullet point for #1252