add check metadatahash signed extension #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official documentation recommends to not enable the metadata-hash computation at build time by default because it needs to compile the runtime twice (which doesn't double the build-time). Hence, it is advisable to feature gate it to speed-up regular build-times. However, I am not sure if it is worth to increase the build-complexity because of this. The fellowship has feature gated it like this.
On my machine, I get the following build times for a collator build (partial build, starting from roughly same crate):
Hence, the difference is kind of small, and I don't think it is worth it. However, if we establish the concept of an onchain-release build anyhow, we can change that in the future.
Todo: