Allow reserve asset transfer of relaychain token to parachain and back #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
changed the title
brenzi
commented
Feb 9, 2024
| pub ExistentialDeposits: |currency_id: CurrencyId| -> Balance { | ||
| match currency_id { | ||
| CurrencyId::TEER => MILLITEER, | ||
| CurrencyId::RelayNative => 3_333_333u128.into() // keep this with asset hub ED |
There was a problem hiding this comment.
would be nicer to call this KSM, but as we want to have one runtime for KSM and DOT, we may keep it generic RelayNative
brenzi
commented
Feb 9, 2024
| @@ -861,10 +921,6 @@ mod benches { | |||
| [pallet_child_bounties, ChildBounties] | |||
| [pallet_claims, Claims] | |||
| [pallet_collective, Council] | |||
| // Fixme #177: For some reason the benchmarks write both to the same pallet_collective weight | |||
There was a problem hiding this comment.
I see no reason to fix this. of course the benchmark is the same for two instances of the same pallet
brenzi
commented
Feb 9, 2024
| _ => None, | ||
| }, | ||
| MultiLocation { parents, interior } if parents == 0 => match interior { | ||
| X1(junction) if junction == TEER_GENERAL_KEY => Some(CurrencyId::TEER), | ||
| Here => Some(CurrencyId::TEER), |
There was a problem hiding this comment.
I think we'll need that because that will be how Asset Hub refers to TEER (different from Karura, Moonriver style)
3 tasks
|
orml_tokens / orml_currencies do not implement I guess the decision to use ORML for this was wrong |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step to bring TEER to Asset Hub is to bring KSM to Integritee (to pay xcm fees with)
This PR allows to
the chosen solutions are inspired from Karura and Trappist
sanity checks:
do not merge just yet
This PR makes a design decision that we may want to iterate on!
testing
start zombienet
send 1 ROC from relaychain to integritee network
you should see
tokens.DepositedEvent on Integritee Networkcheck balance:
send funds from Alice to Bob
send ROC back from Bob to Bob on relaychain