-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to polkadot v1.3.0 #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me
hmm, runtime-benchmark build works, but
this here works, however: |
for the sake of completeness, I tested that the parachain template in polkadot-sdk works correctly:
works as expected |
closes #250
design decision:
Maintenance of node code is easier if we don't attempt to make service.rs generic. I think code redundancy is the lesser evil than maintenance effort here: we can simply copy-paste the template code and adjust two lines
must re-run benchmarks