Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to polkadot v1.3.0 #259

Merged
merged 29 commits into from
Feb 7, 2024
Merged

upgrade to polkadot v1.3.0 #259

merged 29 commits into from
Feb 7, 2024

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Feb 2, 2024

closes #250

design decision:

  • Maintenance of node code is easier if we don't attempt to make service.rs generic. I think code redundancy is the lesser evil than maintenance effort here: we can simply copy-paste the template code and adjust two lines

  • must re-run benchmarks

@brenzi brenzi requested a review from clangenb February 2, 2024 10:24
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me

polkadot-parachains/src/cli.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@brenzi
Copy link
Collaborator Author

brenzi commented Feb 5, 2024

hmm, runtime-benchmark build works, but

cargo build --release --features runtime-benchmarks
./target/release/integritee-collator benchmark pallet --list --chain integritee-rococo-local-dev
Error: Input("Did not find the benchmarking metadata. This could mean that you either did not build the node correctly with the `--features runtime-benchmarks` flag, or the chain spec that you are using was not created by a node that was compiled with the flag: Other: Exported method Benchmark_benchmark_metadata is not found")

this here works, however:
./target/release/integritee-collator benchmark storage --chain integritee-rococo-local-dev --state-version 0

@brenzi
Copy link
Collaborator Author

brenzi commented Feb 6, 2024

for the sake of completeness, I tested that the parachain template in polkadot-sdk works correctly:

cargo build --release --features runtime-benchmarks -p parachain-template-node
./target/release/parachain-template-node benchmark pallet --list --chain dev

works as expected

@brenzi brenzi merged commit 6d3ef2f into master Feb 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to polkadot-v1.3.0 and depend on crates.io
2 participants