On chain DCAP verification #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
reviewed
Jan 12, 2023
clangenb
reviewed
Jan 13, 2023
OverOrion
reviewed
Jan 16, 2023
|
@clangenb @OverOrion I think I addressed all the issues. If I did not reply I either thought that the comment was outdated or that I fixed it in code. Please check if you agree. |
clangenb
approved these changes
Jan 19, 2023
OverOrion
reviewed
Jan 23, 2023
OverOrion
approved these changes
Jan 23, 2023
OverOrion
approved these changes
Jan 25, 2023
clangenb
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Initial version of on chain verification * Rename from report to quote * Add unit tests for decoding * Implement signature check for TcbInfo and QeIdentity * Cleanup * Documentation * Use size_of from core instead of std * Deserialize EnclaveIdentity * Refactor into smaller methods * Add collateral data and improve tests * Improve test * Work on CRL parsing * Make hex compatible to no_std * Change license just in case... * Cleanup * Cleanup * Cleanup * Add data structures for TcbInfo collateral * Work towards registering the quoting enclave * Work towards registering the tcb info * Adjust weights to polkadot-v0.9.29 * Switch to ring-xous * Improve error handling and logging * Cleanups and documentation * Get rid of dangerous unwrap * Error handling and cleanup * Switch to collateral version v4 * Switch to DateTime instead of String * Move collateral data to separate file * Add more validation logic and tests * Improve collateral handling and work towards registering the quoting enclave * Switch license to GPL-3.0 * Register quoting enclave * Add check for mrenclave * More checks and error-handling * Deserialize more parts of the collateral * Remove unneccessary check * Expand checks for quoting enclave * Add dummy support to register TCB info * Add code to extract certificate information * Rename ias-verify crate to sgx-verify as it verifies dcap as well * Work towards storing TCB info on chain * Store TCB info on chain * Store TCB info on chain * Define fmspc as byte array * Store the correct FMSPC * Verify TCB info * Verify TCB info * Add register_quoting_enclave unittest * Add register_tcb_info unittest * Make the add_and_remove_dcap_enclave_works test work again * Add a check to prevent out of memory issues * Cleanup * Clippy fixes * Deal with potential errors that happen during DER encoding * Separate verification and putting collateral on chain more strictly * Cleanup log messages * Add some fuzz tests * Remove unnecessary pub * Update Cargo.lock after merge and fix clippy issues * Fix clippy issue * Fix test issues * Remove unused code * Move the code for the unfinished CRL handling into a unit test * Make clippy happy * Add comment on how to extract the code for a certificate anchor * Add fuzz test for extract_tcb_info * Cleanup and documentation * Incorporate review feedback * Introduce type alias for mrsigner and mrenclave * Incorporate review feedback * Incorporate review feedback * Incorporate review feedback * Add another fuzz test * Enable std features for std-compilation * Cleanup * Incorporate review feedback * Add clarifying comment (cherry picked from commit 20f7318)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.