Add support for end-of-options flag (--) #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All parameters after the -- flag will be passed directly to helm. Fixes instrumenta#5
|
Closing since the project seems abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All parameters after the
--flag will be passed directly to helm.Example usage looks like
This is useful for the reasons described in #5; specifically,
helm templatesupports a--versionflag that is currently intercepted by helm-kubeval, with no way to pass it through.Based on the implementation of
run.shit looks like this feature was intended to be supported, because there's aneoo(end-of-options) variable that is checked but never set. Ifeoois ever nonzero (which it cannot be in its current state), then all options go straight tohelmwithout be intercepted.