Skip to content

Commit

Permalink
Merge bitcoin#28835: test: Check error details with assert_debug_log …
Browse files Browse the repository at this point in the history
…on the assumeutxo invalid hash dump - follow-up bitcoin#28698

7de7685 test, assumeutxo: Use assert_debug_log for error details (pablomartin4btc)

Pull request description:

  This is a follow-up on the invalid hash dump fix bitcoin#28698, [suggested](bitcoin#28698 (review)) by theStack and agreed by Sjors and ryanofsky.

ACKs for top commit:
  Sjors:
    ACK 7de7685
  maflcko:
    lgtm ACK 7de7685

Tree-SHA512: 036b3cef3084e3ead8923e8dcabe4fa7ebe97fb514d223aa38bc38df10337e3fe3113e42322178b58fb03fcd4511af4b5b56bceecbb7ded5b9758842c70db3f2
  • Loading branch information
fanquake committed Nov 10, 2023
2 parents b3898e9 + 7de7685 commit 1fdd832
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions test/functional/feature_assumeutxo.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,14 @@ def test_invalid_chainstate_scenarios(self):
chainstate_snapshot_path.mkdir()
with open(chainstate_snapshot_path / "base_blockhash", 'wb') as f:
f.write(b'z' * 32)
expected_error = f"Error: A fatal internal error occurred, see debug.log for details"
self.nodes[0].assert_start_raises_init_error(expected_msg=expected_error)

def expected_error(log_msg="", error_msg=""):
with self.nodes[0].assert_debug_log([log_msg]):
self.nodes[0].assert_start_raises_init_error(expected_msg=error_msg)

expected_error_msg = f"Error: A fatal internal error occurred, see debug.log for details"
error_details = f"Assumeutxo data not found for the given blockhash"
expected_error(log_msg=error_details, error_msg=expected_error_msg)

# resurrect node again
rmtree(chainstate_snapshot_path)
Expand Down

0 comments on commit 1fdd832

Please sign in to comment.