Make getFormulaFragmentId() a public function. #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Code Coverage 97.16% ✅
Generated by 🚫 Danger |
Jawnnypoo
approved these changes
Oct 8, 2024
What do you mean? |
Jawnnypoo
reviewed
Oct 8, 2024
| key = getFragmentKey() | ||
| ) | ||
| } |
There was a problem hiding this comment.
Every time someone calls this, it generates a new FragmentId object, which may be unexpected. Usually a get function doesn't allocate anything new, so this might be unexpected. But I don't know the usecase of this, so it could be fine.
There was a problem hiding this comment.
It's a tiny data class, should be completely fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Making this into a public API.