This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
BibCheck: new plugin #290
Open
BibCheck: new plugin #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsgit
force-pushed
the
new-bibcheck-plugin
branch
from
098d333
to
51a381a
Compare
|
Allow for additional filter? |
| for pos, val in record.iterfield(subfield): | ||
| if subfieldre.match(val): | ||
| count = 0 | ||
| for spos, _ in record.iterfield(subfield[0:5] + '%'): |
There was a problem hiding this comment.
in the end:
count = len(record[pos[0][0:3]][pos[1]][0])
and wouldn't it be better if bibcheck learns to delete empty subfields (and empty tags)?
* plugin remove_subfield_matching
* removes subfield matching regexp or entire tag
* optionally filter by subfield
Signed-off-by: Thorsten Schwander <[email protected]>
tsgit
force-pushed
the
new-bibcheck-plugin
branch
from
51a381a
to
99dd36c
Compare
|
added optional subfield_filter, although the regexp itself should probably sufficiently specific to match no more than what should be removed. Also, if the subfield filter specifies a provenance and there are no other subfields, only the matching subfield will be removed and the provenance stays behind. In this case remove_entire_tag would be a more appropriate action -- but that should be a separate plugin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thorsten Schwander [email protected]