Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vhvapm 531 #3

Merged
merged 13 commits into from
Aug 30, 2024
Merged

Feature/vhvapm 531 #3

merged 13 commits into from
Aug 30, 2024

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Aug 28, 2024

No description provided.

Copy link
Member Author

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller stuff

@EddeCCC
Copy link
Member Author

EddeCCC commented Aug 28, 2024

@levinkerschberger Could you also add SonarCloud to this repository?

@EddeCCC
Copy link
Member Author

EddeCCC commented Aug 29, 2024

@binarycoded Looks good :)

For consistency, shouldn't we also remove the @Builder annotation from ConnectionDto and Agent for the same reason as in CreateConnectionRequest?

Copy link

sonarcloud bot commented Aug 29, 2024

@EddeCCC
Copy link
Member Author

EddeCCC commented Aug 29, 2024

@levinkerschberger @binarycoded Approved :)

@NTTechnicalUser NTTechnicalUser merged commit b73b043 into main Aug 30, 2024
2 checks passed
@levinkerschberger levinkerschberger deleted the feature/VHVAPM-531 branch August 30, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants