Add strict padding setting to the nclient4

[Bogdan-Denisenko]

RFC 2132 says:
The end option marks the end of valid information in the vendor field. Subsequent octets should be filled with pad options.

But it seems that this does not mean that the client should consider packages with non-pad options after the End option invalid, because RFC 2119 explains:
3. SHOULD This word, or the adjective "RECOMMENDED", mean that there may exist valid reasons in particular circumstances to ignore a particular item, but the full implications must be understood and carefully weighed before choosing a different course.

This PR is an alternative to #543, with zero padding checking disabled by default.

[Bogdan-Denisenko]

@pmazzini review required

[pmazzini]

What would be the problem of not having a strictPadding option?

[Bogdan-Denisenko]

What would be the problem of not having a strictPadding option?

I don't really know in what case this option might be useful. Do you think it's better to just remove the zero padding check without the option to enable it?

[soumiksamanta]

I am too blocked on this. We wanted to move from ISC DHCP to our own targeted implementation of DHCP. Waiting for this to get merged to master. This would be really helpful.

[hugelgupf]

Let’s try just removing the check. If it breaks someone, we can have the option later.

…

On Sun, Aug 25, 2024 at 22:05 Soumik Samanta ***@***.***> wrote: I am too blocked on this. We wanted to move from ISC DHCP to our own targeted implementation of DHCP. Waiting for this to get merged to master. This would be really helpful. — Reply to this email directly, view it on GitHub <#545 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPG3ETZDPHBRWG4APC6EMLZTI2JZAVCNFSM6AAAAABMADFLOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYHE3TMMBRGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Bogdan-Denisenko]

Let’s try just removing the check. If it breaks someone, we can have the option later.
…
On Sun, Aug 25, 2024 at 22:05 Soumik Samanta @.> wrote: I am too blocked on this. We wanted to move from ISC DHCP to our own targeted implementation of DHCP. Waiting for this to get merged to master. This would be really helpful. — Reply to this email directly, view it on GitHub <#545 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPG3ETZDPHBRWG4APC6EMLZTI2JZAVCNFSM6AAAAABMADFLOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYHE3TMMBRGQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

Opened PR with removed zero padding check - #546.

[pmazzini]

Continuation in #546