Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating code - Bonus Track #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updating code - Bonus Track #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions client3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,17 @@ def getDataPoint(quote):
stock = quote['stock']
bid_price = float(quote['top_bid']['price'])
ask_price = float(quote['top_ask']['price'])
price = bid_price
price = (bid_price+ask_price)/2
return stock, bid_price, ask_price, price

def getRatio(price_a, price_b):
""" Get ratio of price_a and price_b """
""" ------------- Update this function ------------- """
""" Also create some unit tests for this function in client_test.py """
return 1
if price_b == 0:
# when price_b is 0 avoid throwing ZeroDivisionError
return
return price_a/price_b

# Main
if __name__ == "__main__":
Expand All @@ -52,8 +55,10 @@ def getRatio(price_a, price_b):
quotes = json.loads(urllib.request.urlopen(QUERY.format(random.random())).read())

""" ----------- Update to get the ratio --------------- """
prices = {}
for quote in quotes:
stock, bid_price, ask_price, price = getDataPoint(quote)
prices[stock] = price
print ("Quoted %s at (bid:%s, ask:%s, price:%s)" % (stock, bid_price, ask_price, price))

print ("Ratio %s" % getRatio(price, price))
print ("Ratio %s" % (getRatio(prices['ABC'], prices['DEF'])))
36 changes: 34 additions & 2 deletions client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import unittest
from client3 import getDataPoint
from client3 import getDataPoint, getRatio

class ClientTest(unittest.TestCase):
def test_getDataPoint_calculatePrice(self):
Expand All @@ -8,18 +8,50 @@ def test_getDataPoint_calculatePrice(self):
{'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'}
]
""" ------------ Add the assertion below ------------ """
for quote in quotes:
self.assertEqual(
getDataPoint(quote),
(
quote['stock'],
quote['top_bid']['price'],
quote['top_ask']['price'],
(quote['top_bid']['price'] + quote['top_ask']['price'])/2)
)


def test_getDataPoint_calculatePriceBidGreaterThanAsk(self):
quotes = [
{'top_ask': {'price': 119.2, 'size': 36}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 120.48, 'size': 109}, 'id': '0.109974697771', 'stock': 'ABC'},
{'top_ask': {'price': 121.68, 'size': 4}, 'timestamp': '2019-02-11 22:06:30.572453', 'top_bid': {'price': 117.87, 'size': 81}, 'id': '0.109974697771', 'stock': 'DEF'}
]
""" ------------ Add the assertion below ------------ """
for quote in quotes:
self.assertEqual(
getDataPoint(quote),
(
quote['stock'],
quote['top_bid']['price'],
quote['top_ask']['price'],
(quote['top_bid']['price'] + quote['top_ask']['price'])/2)
)


""" ------------ Add more unit tests ------------ """
def test_getRatio_calculatePriceBEqualToZero(self):
quotes = [
{'price_a': 54, 'price_b': 0},
{'price_a': 421.2, 'price_b': 0},
]
""" ------------ Add the assertion below ------------ """
print("Ratio is:",
getRatio(1,0)
)


for quote in quotes:
self.assertEqual(
getRatio(quote['price_a'],quote['price_b']),
None
)

if __name__ == '__main__':
unittest.main()