-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor aggregator pruning with upkeep service #2103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
force-pushed
the
sfa/2075/refactor_pruning_with_upkeep_service
branch
from
November 8, 2024 16:37
c66d1b8
to
44a4cfb
Compare
sfauvel
force-pushed
the
sfa/2075/refactor_pruning_with_upkeep_service
branch
from
November 8, 2024 16:45
44a4cfb
to
e4ee45b
Compare
sfauvel
temporarily deployed
to
testing-preview
November 8, 2024 16:54
— with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
November 8, 2024 16:54
— with
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2075/refactor_pruning_with_upkeep_service
branch
from
November 12, 2024 08:27
e4ee45b
to
2f1f5dd
Compare
sfauvel
temporarily deployed
to
testing-preview
November 12, 2024 08:35
— with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
November 12, 2024 08:35
— with
GitHub Actions
Inactive
sfauvel
changed the title
Refactor pruning with upkeep service
Refactor aggregator pruning with upkeep service
Nov 12, 2024
dlachaume
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
internal/mithril-persistence/src/sqlite/connection_extensions.rs
Outdated
Show resolved
Hide resolved
jpraynaud
reviewed
Nov 12, 2024
sfauvel
force-pushed
the
sfa/2075/refactor_pruning_with_upkeep_service
branch
from
November 12, 2024 11:08
2f1f5dd
to
f313498
Compare
sfauvel
temporarily deployed
to
testing-preview
November 12, 2024 11:16
— with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
November 12, 2024 11:16
— with
GitHub Actions
Inactive
jpraynaud
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* mithril-persistence from `0.2.31` to `0.2.32` * mithril-aggregator from `0.5.107` to `0.5.108`
sfauvel
force-pushed
the
sfa/2075/refactor_pruning_with_upkeep_service
branch
from
November 12, 2024 13:36
f313498
to
ef8feb1
Compare
sfauvel
temporarily deployed
to
testing-preview
November 12, 2024 13:44
— with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
November 12, 2024 13:44
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR remove the pruning from the
save
function and use the upkeep service instead.The
EpochPruningTask
is implemented in theAggregator
for theStakePoolStore
andEpochSettingsStore
Pre-submit checklist
Comments
Issue(s)
Relates to #2075