Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-8828 - Check that contract is not mixing mainnet and testnet addresses before sending to Runner #66

Merged
merged 4 commits into from
Feb 1, 2024
Merged

PLT-8828 - Check that contract is not mixing mainnet and testnet addresses before sending to Runner #66

merged 4 commits into from
Feb 1, 2024

Conversation

palas
Copy link
Collaborator

@palas palas commented Jan 27, 2024

This PR:

  • Adds a linter warning for whenever there are networks from both testnet and mainnet
  • Forbids sending contracts to Marlowe Runner when networks mismatch or they are for mainnet (since it is not supported yet)

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@palas palas added the enhancement New feature or request label Jan 27, 2024
@palas palas requested review from paluh and hrajchert January 27, 2024 20:42
@palas palas self-assigned this Jan 27, 2024
@palas palas merged commit b83d246 into main Feb 1, 2024
6 checks passed
@palas palas deleted the PLT-8828 branch February 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paluh paluh Awaiting requested review from paluh

@hrajchert hrajchert Awaiting requested review from hrajchert

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@palas