Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-7568 - Make graying out of boilerplate of TypeScript editor darker #58

Merged
merged 1 commit into from
Nov 21, 2023
Merged

PLT-7568 - Make graying out of boilerplate of TypeScript editor darker #58

merged 1 commit into from
Nov 21, 2023

Conversation

palas
Copy link
Collaborator

@palas palas commented Nov 20, 2023 •
edited
Loading

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Before:
image

After:
image

@palas palas added the enhancement New feature or request label Nov 20, 2023
@palas palas self-assigned this Nov 20, 2023
@palas palas requested a review from bwbush November 20, 2023 11:48
bwbush
bwbush approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the darker shade of gray!

@palas palas merged commit 804266f into main Nov 21, 2023
5 checks passed
@palas palas deleted the PLT-7568 branch November 21, 2023 12:45
@palas palas changed the title PLT-7568 - Make greying out of boilerplate of TypeScript editor darker PLT-7568 - Make graying out of boilerplate of TypeScript editor darker Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbush bwbush bwbush approved these changes

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @bwbush