Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update the node's prometheus metrics #4142

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

saibatizoku
Copy link
Contributor

Updates jormungandr node to initialize mempool and peer gauges to 0.

Closes input-output-hk/catalyst-core#600

@saibatizoku saibatizoku added the enhancement New feature or request label Nov 1, 2023
@saibatizoku saibatizoku self-assigned this Nov 1, 2023
@cong-or
Copy link
Contributor

cong-or commented Nov 2, 2023

golden commit: 47e874c

we should make a branch off this and put all changes in here for A/B testing.

@kukkok3
Copy link
Contributor

kukkok3 commented Nov 2, 2023

Would not be better to wait until we have a stable jor node version and merge this change into that?

@cong-or
Copy link
Contributor

cong-or commented Nov 2, 2023

Would not be better to wait until we have a stable jor node version and merge this change into that?

yea but we want to compare the "new" nodes performance vs the old node.

[Old:](golden commit: 47e874c)

New: Branch from gold. Silver?

@saibatizoku
Copy link
Contributor Author

Would not be better to wait until we have a stable jor node version and merge this change into that?

yea but we want to compare the "new" nodes performance vs the old node.

[Old:](golden commit: 47e874c)

New: Branch from gold. Silver?

I think that we can rename to whichever name is better suited to do A/B testing (e.g. branch-A, branch-B), and create a tag when we have reached a conclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jormungandr metrics that need to be reset when the node (re-)starts.
4 participants